From: Andrew Lunn <andrew@lunn.ch>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@kernel.org>,
Denis Benato <benato.denis96@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH] net: fealnx: make driver work on architectures without I/O ports
Date: Tue, 28 Apr 2026 15:03:53 +0200 [thread overview]
Message-ID: <17af8886-7be9-411a-8067-feb59eae2c7d@lunn.ch> (raw)
In-Reply-To: <20260428021145.40930-1-enelsonmoore@gmail.com>
On Mon, Apr 27, 2026 at 07:11:36PM -0700, Ethan Nelson-Moore wrote:
> Devices supported by the fealnx driver support both MMIO and PIO access
> (they have a PCI BAR for each). However, the driver always tries to use
> the PIO BAR on architectures other than Alpha. This makes the driver
> not work on architectures without I/O port mapping support. The comment
> explaining why this was done explains that some x86 systems have issues
> with MMIO. To enable the driver on all architectures while preventing
> potential regressions, change the driver to only use PIO on x86.
>
> Issue discovered by manual inspection.
Does that mean it is untested? Probably broken?
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Given that nobody has cared about this for the last 20 years, why
change it now?
Please stop making changes to old drivers, unless you have the
hardware in your hands and you have a real problem with it. If those
conditions are not met, you are just wasting peoples time.
If you want to do something useful, please spend some time reviewing
other peoples patches. Or get some real hardware in your hands and add
new features to its driver.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-04-28 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 2:11 [PATCH] net: fealnx: make driver work on architectures without I/O ports Ethan Nelson-Moore
2026-04-28 13:03 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17af8886-7be9-411a-8067-feb59eae2c7d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=benato.denis96@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox