From: Florian Fainelli <f.fainelli@gmail.com>
To: Mason <slash.tmp@free.fr>, netdev <netdev@vger.kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Mans Rullgard <mans@mansr.com>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>
Subject: Re: Toggling link state breaks network connectivity
Date: Tue, 13 Jun 2017 08:36:13 -0700 [thread overview]
Message-ID: <17e1e9c3-7adb-05fe-18cd-ce6db4ac792d@gmail.com> (raw)
In-Reply-To: <b3d1fd0c-281a-dd5a-d0e8-75f42475a248@free.fr>
On 06/13/2017 08:07 AM, Mason wrote:> I did note something that seems
important.
>
> If I toggle the link state in software, then connectivity breaks.
>
> If I unplug the ethernet cable, and replug, connectivity remains.
What does that actually mean? If you disconnect the cable a link state
should be notified and another link state should be notified, even if
that happens faster than the PHYLIB polling time (1s).
>
> The difference is that plugging/unplugging doesn't call the
> .ndo_stop callback. But 'ip link set eth0 down' does call it.
>
> Should the .ndo_stop callback be symmetric to the .ndo_open callback?
Yes obviously.
> In other words, should .ndo_open(); .ndo_stop(); be a NOP?
--
Florian
next prev parent reply other threads:[~2017-06-13 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 13:22 Toggling link state breaks network connectivity Mason
2017-06-12 16:38 ` Florian Fainelli
2017-06-12 18:58 ` Mason
2017-06-13 15:07 ` Mason
2017-06-13 15:32 ` Mason
2017-06-13 15:36 ` Florian Fainelli [this message]
2017-06-13 15:47 ` Mason
2017-06-13 15:50 ` Florian Fainelli
2017-06-14 14:49 ` Mason
2017-06-15 10:19 ` Måns Rullgård
2017-06-16 14:18 ` Mason
2017-06-13 9:39 ` Matthias May
2017-06-13 14:20 ` Mason
2017-06-13 14:40 ` Matthias May
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e1e9c3-7adb-05fe-18cd-ce6db4ac792d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox