From: Florian Fainelli <f.fainelli@gmail.com>
To: "Marek Behún" <marek.behun@nic.cz>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X
Date: Mon, 28 Jan 2019 12:34:59 -0800 [thread overview]
Message-ID: <1807bad2-30dd-dcdc-320e-fc71bb0f3c0b@gmail.com> (raw)
In-Reply-To: <20190124154309.24987-1-marek.behun@nic.cz>
On 1/24/19 7:43 AM, Marek Behún wrote:
> Commit 787799a9d555 sets the SERDES interfaces of 6390 and 6390X to
> 1000BaseX, but this is only needed on 6390X, since there are SERDES
> interfaces which can be used on lower ports on 6390.
>
> This commit fixes this by returning to previous behaviour on 6390.
> (Previous behaviour means that CMODE is not set at all if requested mode
> is NA).
>
> This is needed on Turris MOX, where the 88e6190 is connected to CPU in
> 2500BaseX mode.
>
> Fixes: 787799a9d555 ("net: dsa: mv88e6xxx: Default ports 9/10 6390X CMODE to 1000BaseX")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
I suppose for now, this is the best way to approach that problem given
the shortcomings of the fixed link support in net/dsa/port.c:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
prev parent reply other threads:[~2019-01-28 20:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:43 [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Marek Behún
2019-01-24 15:43 ` [PATCH net-next v1 2/2] net: dsa: mv88e6xxx: Fix phylink_validate for Topaz family Marek Behún
2019-01-24 16:01 ` Andrew Lunn
2019-01-24 16:11 ` [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Andrew Lunn
2019-01-24 16:29 ` Marek Behun
2019-01-24 16:48 ` Andrew Lunn
2019-01-24 18:04 ` Marek Behun
2019-01-24 18:11 ` Andrew Lunn
2019-01-24 19:24 ` Marek Behun
2019-01-24 19:27 ` Florian Fainelli
2019-01-24 19:31 ` Andrew Lunn
2019-01-24 19:37 ` Marek Behun
2019-01-24 19:56 ` Florian Fainelli
2019-01-24 19:39 ` Marek Behun
2019-01-25 18:48 ` Florian Fainelli
2019-01-25 19:25 ` Marek Behun
2019-01-28 20:34 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1807bad2-30dd-dcdc-320e-fc71bb0f3c0b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).