From: Davide Benini <davide.benini@suse.com>
To: "Michal Koutný" <mkoutny@suse.com>, netdev@vger.kernel.org
Cc: mkubecek@suse.cz
Subject: Re: [PATCH] ss: Tone down cgroup path resolution
Date: Tue, 18 Feb 2025 14:11:06 +0100 [thread overview]
Message-ID: <1818b3c8-b952-4dba-8b46-a3175adaeb8e@suse.com> (raw)
In-Reply-To: <20250210141103.44270-1-mkoutny@suse.com>
On 10/02/25 15:11, Michal Koutný wrote:
> Sockets and cgroups have different lifetimes (e.g. fd passing between
> cgroups) so obtaining a cgroup id to a removed cgroup dir is not an
> error. Furthermore, the message is printed for each such a socket.
> Improve user experience by silencing these specific errors.
Note that if ss has been called with -e (to show detailed socket information) or with --cgroup (to show cgroup information), even if the message "Failed to open cgroup2 by ID" will no longer appear, however the cg_id_to_path() will return a string "unreachable:%llx" and the output will still be similar to
tcp LISTEN 0 4096 [::]:2049 [::]:* ino:710321 sk:10da cgroup:unreachable:8ed7 v6only:1 <->
But I agree that removing the specific error message would be enough to prevent customer concern.
Davide Benini
next prev parent reply other threads:[~2025-02-18 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 14:11 [PATCH] ss: Tone down cgroup path resolution Michal Koutný
2025-02-18 13:11 ` Davide Benini [this message]
2025-02-18 13:40 ` Michal Koutný
2025-02-20 22:20 ` Stephen Hemminger
2025-02-21 9:32 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1818b3c8-b952-4dba-8b46-a3175adaeb8e@suse.com \
--to=davide.benini@suse.com \
--cc=mkoutny@suse.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).