From: "Michal Kubeček" <mkubecek@suse.cz>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.hengli.com.au>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Shan Wei <shanwei@cn.fujitsu.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [RFC Patch net-next] ipv6: unify conntrack reassembly expire code with standard one
Date: Fri, 17 Aug 2012 19:05:57 +0200 [thread overview]
Message-ID: <1826853.rak2U42CMU@alaris> (raw)
In-Reply-To: <1345190565-21689-1-git-send-email-amwang@redhat.com>
On Friday 17 of August 2012 16:02EN, Cong Wang wrote:
> Two years ago, Shan Wei tried to fix this:
> http://patchwork.ozlabs.org/patch/43905/
>
...
>
> As Herbert suggested, we could actually use the standard IPv6
> reassembly code which follows RFC2460.
I tested the patch and I ran into a problem in this place in
ip6_expire_frag_queue():
> net = container_of(fq->q.net, struct net, ipv6.frags);
For frag queues coming from IPv6 conntrack, fq->q.net points to
nf_init_frags which is not embedded into struct net so that the
following device lookup leads to reading from an invalid address.
The same problem has been discussed on the page linked above.
I didn't test with current net-next source but as far as I can tell,
this hasn't changed. Did I miss something?
Michal Kubecek
next prev parent reply other threads:[~2012-08-17 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 8:02 [RFC Patch net-next] ipv6: unify conntrack reassembly expire code with standard one Cong Wang
2012-08-17 17:05 ` Michal Kubeček [this message]
2012-08-20 9:06 ` Cong Wang
2012-08-20 20:21 ` Michal Kubecek
2012-08-21 13:38 ` Cong Wang
2012-08-24 10:13 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1826853.rak2U42CMU@alaris \
--to=mkubecek@suse.cz \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shanwei@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).