From: Jay Vosburgh <fubar@us.ibm.com>
To: Phil Oester <kernel@linuxace.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
David Miller <davem@davemloft.net>,
bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 net-next][v2] bonding: fix incorrect transmit queue offset
Date: Fri, 04 Mar 2011 09:37:51 -0800 [thread overview]
Message-ID: <18279.1299260271@death> (raw)
In-Reply-To: <20110302014009.GA2045@linuxace.com>
Phil Oester <kernel@linuxace.com> wrote:
>On Tue, Mar 01, 2011 at 10:31:36AM -0500, Andy Gospodarek wrote:
>> > The patch works as expected. Do we have any agreement on a final version?
>> >
>>
>> Thanks for the testing, Phil.
>>
>> I'm in favor of this patch as it does alert the admin that bonding may
>> not have enough default queues, but it is not as verbose (backtrace et
>> al) and likely to create bug reports as a message from WARN_ON.
>> + if (net_ratelimit())
>> + pr_warning("%s selects invalid tx queue %d. Consider"
>> + " setting module option tx_queues > %d.",
>> + dev->name, txq, dev->real_num_tx_queues);
>
>It is unclear why we need to alert the admin to this situation (repeatedly).
>Say the incoming nic has 32 queues, and is headed out a bond (with 16).
>With your patch, we will log 50% of the time, no? What benefit is this
>log spew?
>
>While WARN_ONCE may be a bit extreme due to the backtrace, perhaps we
>should at least throw a 'static bool warned' variable in there to lessen
>the nuisance?
I'm also concerned that the log messages will be excessive.
Should we instead create a bonding driver-private ethtool
statistics and count these events that way?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
prev parent reply other threads:[~2011-03-04 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 19:42 [PATCH 1/2] bonding: fix incorrect transmit queue offset Andy Gospodarek
2011-02-23 22:19 ` Jay Vosburgh
2011-02-23 23:12 ` Andy Gospodarek
2011-02-23 23:08 ` Phil Oester
2011-02-23 23:13 ` David Miller
2011-02-23 23:37 ` Ben Hutchings
2011-02-23 23:43 ` Andy Gospodarek
2011-02-23 23:54 ` David Miller
2011-02-25 22:56 ` Phil Oester
2011-03-01 15:31 ` [PATCH 1/2 net-next][v2] " Andy Gospodarek
2011-03-02 1:40 ` Phil Oester
2011-03-04 17:37 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18279.1299260271@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kernel@linuxace.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).