netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Lehner <dev@der-flo.net>
To: netdev@vger.kernel.org
Subject: [PATCH v2] ss: Enclose IPv6 address in brackets
Date: Mon, 31 Jul 2017 21:50:04 +0200	[thread overview]
Message-ID: <182a039f-5e8f-3c37-a32b-ae4562c57c1c@der-flo.net> (raw)
In-Reply-To: <fc81757c-8dbb-dbed-7a24-7011cb8bb9e0@der-flo.net>

This updated patch adds support for RFC2732 IPv6 address format with
brackets for the tool ss. Resolved hostnames will not be enclosed in
brackets, therefore the global variable resolve_hosts is initialized and
checked.

Signed-off-by: Lehner Florian <dev@der-flo.net>
---
 misc/ss.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/misc/ss.c b/misc/ss.c
index 12763c9..ac94537 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -88,7 +88,7 @@ static int security_get_initial_context(char *name,
char **context)
 }
 #endif

-int resolve_hosts;
+int resolve_hosts = 0;
 int resolve_services = 1;
 int preferred_family = AF_UNSPEC;
 int show_options;
@@ -1059,7 +1059,11 @@ static void inet_addr_print(const inet_prefix *a,
int port, unsigned int ifindex
 			ap = format_host(AF_INET, 4, a->data);
 		}
 	} else {
-		ap = format_host(a->family, 16, a->data);
+		if (a->family == AF_INET6 && !resolve_hosts) {
+			sprintf(buf, "[%s]", format_host(a->family, 16, a->data));
+		} else {
+			ap = format_host(a->family, 16, a->data);
+		}
 		est_len = strlen(ap);
 		if (est_len <= addr_width)
 			est_len = addr_width;
-- 
2.9.4

  parent reply	other threads:[~2017-07-31 19:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-29 12:29 [PATCH] ss: Enclose IPv6 address in brackets Florian Lehner
2017-07-29 15:26 ` Stephen Hemminger
2017-07-31 10:30 ` Phil Sutter
2017-07-31 16:27   ` Stephen Hemminger
2017-07-31 16:43     ` Phil Sutter
2017-07-31 18:17   ` Florian Lehner
2017-07-31 19:50 ` Florian Lehner [this message]
2017-07-31 20:27   ` [PATCH v2] " Phil Sutter
2017-08-01 10:05 ` [PATCH v3] " Florian Lehner
2017-08-01 14:11   ` Phil Sutter
2017-08-01 16:07     ` Florian Lehner
2017-08-01 11:11 ` [PATCH] " David Laight
2017-08-01 14:41   ` Stephen Hemminger
2017-08-01 16:54 ` [PATCH v4] " Florian Lehner
2017-08-03 22:54   ` Stephen Hemminger
2017-08-04 18:02 ` [PATCH v5] " Florian Lehner
2017-08-04 19:05   ` Stephen Hemminger
2017-08-04 20:46     ` Eric Dumazet
2017-08-04 22:13       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=182a039f-5e8f-3c37-a32b-ae4562c57c1c@der-flo.net \
    --to=dev@der-flo.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).