From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: Greg KH <greg@kroah.com>
Cc: netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Fwd: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)
Date: Fri, 11 Jul 2014 17:12:55 +0200 [thread overview]
Message-ID: <1836813.giEndUKvmp@storm> (raw)
Hi Greg,
I don't have the original patch email, but please include
the mentioned commit
------------------------------------------
commit 21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
Author: Eric Dumazet <edumazet@google.com>
ipv4: set transport header earlier
------------------------------------------
in the 3.4.x stable tree.
After updating from 3.4.91 to 3.4.96, TCP connections
from Windows 7 clients slowed down to a crawl.
(to be precise: totally unusable)
The commit recommended by Florian Westphal fixes it immediately.
Best regards,
Thomas
---------- Forwarded Message ----------
Subject: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)
Date: Friday, 27. June 2014, 11:05:25
From: Florian Westphal <fw@strlen.de>
To: jungwon park <jwpark2@whitecode.co.kr>
CC: netdev@vger.kernel.org
jungwon park <jwpark2@whitecode.co.kr> wrote:
> When using the linux router is turned on GRO, router send the
'fragmentation
> needed' packets to the sender.
Indeed 8-(
> When I turned off GRO, the router operate normally, and there is no
problem.
> and with 3.4.91 kernel, the router has no problem.
>
> I doubt 'ipv4: ip_forward: fix inverted local_df test' patch.
> (http://patchwork.ozlabs.org/patch/345509/)
> When I revert this patch, the router has no problem.
Can you please cherry-pick following patch on top of vanilla 3.4.92?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
commit 21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
Author: Eric Dumazet <edumazet@google.com>
ipv4: set transport header earlier
I think that should fix this bug, it should apply cleanly on top of
3.4.y tree.
[ patch is in 3.11, also backported to 3.10.y tree ]
The problem is that, when dealing with GRO packets, we try to determine
the size of the individual packets. To do this, we rely on the
transport header.
Unfortunately the transport header is not set for the forward path in 3.4,
so we look at the network header instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-----------------------------------------
next reply other threads:[~2014-07-11 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:12 Thomas Jarosch [this message]
2014-07-30 0:22 ` Fwd: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed) Greg KH
2014-07-30 6:37 ` Florian Westphal
2014-07-31 19:21 ` David Miller
2014-08-05 4:52 ` Fwd: " Greg KH
2014-07-30 11:36 ` Thomas Jarosch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1836813.giEndUKvmp@storm \
--to=thomas.jarosch@intra2net.com \
--cc=fw@strlen.de \
--cc=greg@kroah.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).