From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] bcmgenet: add WOL IRQ check
Date: Thu, 13 Jan 2022 13:37:42 -0800 [thread overview]
Message-ID: <184f55fb-c73b-989b-973e-e9562f511116@gmail.com> (raw)
In-Reply-To: <YeCS6Ld93zCK6aWh@lunn.ch>
On 1/13/2022 1:00 PM, Andrew Lunn wrote:
> On Thu, Jan 13, 2022 at 10:46:07PM +0300, Sergey Shtylyov wrote:
>> The driver neglects to check the result of platform_get_irq_optional()'s
>> call and blithely passes the negative error codes to devm_request_irq()
>> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
>> Stop calling devm_request_irq() with the invalid IRQ #s.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> This patch is against DaveM's 'net.git' repo.
>
> Since this is for net, it needs a Fixes: tag.
>
> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")
I don't have strong objections whether we want to consider this a bug
fix or not, but since the code only acts upon devm_request_irq()
returning 0 meaning success, this seems more like an improvement rather
than fixing an actual issue.
--
Florian
next prev parent reply other threads:[~2022-01-13 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 19:46 [PATCH] bcmgenet: add WOL IRQ check Sergey Shtylyov
2022-01-13 21:00 ` Andrew Lunn
2022-01-13 21:37 ` Florian Fainelli [this message]
2022-01-13 21:47 ` Florian Fainelli
2022-01-14 10:58 ` Sergey Shtylyov
2022-01-14 11:03 ` Sergey Shtylyov
2022-01-14 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184f55fb-c73b-989b-973e-e9562f511116@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).