From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: "Pawlak, Jakub" <jakub.pawlak@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH net] iavf: fix double-release of rtnl_lock
Date: Thu, 3 Dec 2020 17:04:14 +0000 [thread overview]
Message-ID: <1867f98e7951f8d044a7dbf16fcf6a93996914f7.camel@intel.com> (raw)
In-Reply-To: <20201203021806.692194-1-kuba@kernel.org>
On Wed, 2020-12-02 at 18:18 -0800, Jakub Kicinski wrote:
> This code does not jump to exit on an error in iavf_lan_add_device(),
> so the rtnl_unlock() from the normal path will follow.
>
> Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Did you want to apply this or did you want me to take it?
next prev parent reply other threads:[~2020-12-03 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:18 [PATCH net] iavf: fix double-release of rtnl_lock Jakub Kicinski
2020-12-03 17:04 ` Nguyen, Anthony L [this message]
2020-12-03 17:41 ` Jakub Kicinski
2020-12-14 21:23 ` [Intel-wired-lan] " Jankowski, Konrad0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1867f98e7951f8d044a7dbf16fcf6a93996914f7.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.pawlak@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).