From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from server.couthit.com (server.couthit.com [162.240.164.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E7473463; Tue, 24 Mar 2026 06:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.240.164.96 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774332154; cv=none; b=V6BDUKo/oaLlucNB2mT0tPoY3APDsqCxLZ5swlirn9AX3kKclxxXPLOzSg4wJxwimfjSpqqUn3l367BGfAHEBRCi4OjfboxGYzgG3xC9zR5/HuqY9E2KgUxINmiFep+AYA4fOgmr0nYKCSLUxsuNlIj4MQHA2eVr5qmEJAIhJ3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774332154; c=relaxed/simple; bh=MtAiD6nGtZdCXNIhEYglkVSg0RT41DaluimaqjEk3EQ=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=qnic6AmRoQjmQ+aTr8/NlOIwpl5iXDtqeHdhqPPBflNKNia/+DK6/ejbSTNlf2qIqx1KOGGk4uM12JZbIgOICKytHtPAsBZWxPzgQ0Ohb0Bybq1xkBamqoIU14Yf8NDpzCOvch+3k3vuu6TLPLNa8rgbDQfcrh2msxwX90s3hIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=couthit.com; spf=pass smtp.mailfrom=couthit.com; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b=tzcFWWFd; arc=none smtp.client-ip=162.240.164.96 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=couthit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=couthit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b="tzcFWWFd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=couthit.com ; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MojtjraalBHTyEvjeOihKABOGQ7O7vZI1JuIZljaMpg=; b=tzcFWWFdiQTe8BYOt9nt6/1kX0 C4ZLUAcI/cwc0pTZFXR6osQ66bE1xCIeq1xvQflmInLpdgEUJl4hnyvKwTSv2zhONoNRlxqqm3efE rWx8d2oN4An3IYCNCzprzdQODm9gR/abFX+CbyxKcZE5FFRnG+bHfmp9DdysCs3O4E02Ze1YJ1Ty/ hQ7tcZK7YouVQQ0yG0hdhs/cIIrw9roo8gz9WzQz84lpUOZ+yOFniMbCsZMSTaazWk2eTwt2INjOr xE6HdkP5Pt4kvdX2fZFttLNx6GQIFWoTqnNWiM2id4iL8LBjklLaOI7Fg47UKMd+JC+SF4GZ4ls4i A0qeUXDg==; Received: from [115.246.246.98] (port=45793 helo=zimbra.couthit.local) by server.couthit.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1w4uqS-0000000Gv6E-0lP3; Tue, 24 Mar 2026 02:02:28 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id 7C4051B809BF; Tue, 24 Mar 2026 11:32:21 +0530 (IST) Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10032) with ESMTP id YR6KDvbvQtwz; Tue, 24 Mar 2026 11:32:20 +0530 (IST) Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id 7A65F1B81A5B; Tue, 24 Mar 2026 11:32:20 +0530 (IST) X-Virus-Scanned: amavis at couthit.local Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10026) with ESMTP id rNZj4jPXbe6t; Tue, 24 Mar 2026 11:32:20 +0530 (IST) Received: from zimbra.couthit.local (zimbra.couthit.local [10.10.10.103]) by zimbra.couthit.local (Postfix) with ESMTP id 4DFD41B81AB3; Tue, 24 Mar 2026 11:32:20 +0530 (IST) Date: Tue, 24 Mar 2026 11:32:20 +0530 (IST) From: Parvathi Pudi To: Krzysztof Kozlowski Cc: Parvathi Pudi , Kevin Hilman , nm , Vignesh Raghavendra , afd , rogerq , tony , robh , krzk+dt , conor+dt , richardcochran , aaro koskinen , andreas , Andrew Lunn , linux-omap , devicetree , linux-kernel , netdev , danishanwar , pratheesh , j-rameshbabu , praneeth , srk , rogerq , m-malladi , krishna , mohan , pmohan , basharath , Murali Karicheri Message-ID: <1868242922.724201.1774332140293.JavaMail.zimbra@couthit.local> In-Reply-To: References: <20260307122641.738450-1-parvathi@couthit.com> <20260307122641.738450-4-parvathi@couthit.com> <7ho6ks1r4s.fsf@baylibre.com> <91797572.667989.1773662409130.JavaMail.zimbra@couthit.local> Subject: Re: [PATCH v5 3/3] arm: dts: ti: Add device tree support for PRU-ICSS on AM335x Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 9.0.0_ZEXTRAS_20240927 (ZimbraWebClient - GC138 (Linux)/9.0.0_ZEXTRAS_20240927) Thread-Topic: Add device tree support for PRU-ICSS on AM335x Thread-Index: 44ydR5tKwQuKDZuPcpLEgXMqUS7xiQ== X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.couthit.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - couthit.com X-Get-Message-Sender-Via: server.couthit.com: authenticated_id: smtp@couthit.com X-Authenticated-Sender: server.couthit.com: smtp@couthit.com X-Source: X-Source-Args: X-Source-Dir: Hi, > On 16/03/2026 13:00, Parvathi Pudi wrote: >> Hi, >> >>> Parvathi Pudi writes: >>> >>>> From: Roger Quadros >>>> >>>> The TI Sitara AM335x ICE-V2 consists of single PRU-ICSS instance, >>>> This patch adds the new device tree overlay file in-order to enable >>>> PRU-ICSS instance, along with makefile changes. >>>> >>>> PRU-ICSS instance consists of two PRU cores along with various >>>> peripherals such as the Interrupt Controller (PRU_INTC), the Industrial >>>> Ethernet Peripheral(IEP), the Real Time Media Independent Interface >>>> controller (MII_RT), and the Enhanced Capture (eCAP) event module. >>>> >>>> am33xx-l4.dtsi - Adds IEP and eCAP peripheral as child nodes >>>> of the PRUSS subsystem node. >>>> >>>> am335x-icev2-prueth.dtso - Adds PRU-ICSS instance node along with PRU >>>> eth port information and corresponding port configuration. It includes >>>> interrupt mapping for packet reception, HW timestamp collection, and PRU >>>> Ethernet ports in MII mode, >>>> >>>> GPIO configuration, boot strapping along with delay configuration for >>>> individual PRU Ethernet port and other required nodes. >>>> >>>> Signed-off-by: Roger Quadros >>>> Signed-off-by: Andrew F. Davis >>>> Signed-off-by: Murali Karicheri >>>> Signed-off-by: Basharath Hussain Khaja >>>> Signed-off-by: Parvathi Pudi >>> >>> [...] >>> >>>> +/* >>>> + * Disable CPSW switch node and >>>> + * MDIO configuration to prevent >>>> + * conflict with PRU-ICSS >>>> + */ >>>> +&mac_sw { >>>> + status = "disable"; >>>> +}; >>>> + >>>> +&davinci_mdio_sw { >>>> + status = "disable"; >>>> +}; >>> >>> I think you need s/disable/disabled/? (note the trailing 'd'). Without >>> that, I don't think you're disabling these nodes, so I'm curious how it >>> is not conflicting with the PRU-ICSS. >>> >>> Kevin >> >> Thank you for pointing out this typo. >> >> We checked the kernel code as to why this did not create any issue in our >> testing. We found that the device availability check goes through >> of_device_is_available(), which only treats "ok" or "okay" as enabled. >> Anything else is effectively treated as not enabled. >> >> So even though "disable" isn't the usual DT value, it still prevents the >> node from being probed since it doesn't match "ok"/"okay". > > > The question is whether you build tested your code (so dtbs_check). And > if not, why? > We did run dtbs_check as part of our internal testing workflow. However, it is executed within a test framework that runs multiple checks together and is currently trimming part of the dtbs_check output. Because of this, the schema validation warning for "disable" was not visible in the logs we reviewed and we missed catching this error. We have verified that dtbs_check does report this issue, and we will update our test setup to retain full dtbs_check output to avoid missing such warnings in the future. Thanks and Regards, Parvathi.