From: David Howells <dhowells@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com,
syzbot <syzbot+f2c120b449b209d89efa@syzkaller.appspotmail.com>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [crypto?] WARNING in extract_iter_to_sg
Date: Thu, 06 Jul 2023 00:06:02 +0100 [thread overview]
Message-ID: <1869452.1688598362@warthog.procyon.org.uk> (raw)
In-Reply-To: <ZKXoBM7EQfbKKVjG@gondor.apana.org.au>
> CPU: 0 PID: 26699 Comm: syz-executor.2 Not tainted 6.4.0-rc7-syzkaller-01944-g3674fbf0451d #0
Looking at the version string, this is from net-next before the merger with
Linus's tree after the point where Linus had merged:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/?h=for-6.5/splice
> extract_iter_to_sg(3) unsupported
This is ITER_PIPE (type 3) before is removed by:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3fc40265ae2b48a7475c41c5c0b256374c419f4b
From that point on ITER_XARRAY is type 3 and there's a case for that in
extract_iter_to_sg().
So the fix for this is to merge it with the splice tree - which Linus has
already done, so this should be fixed upstream.
With hindsight, I should've used iov_iter_get_pages*() rather than
iov_iter_extract_pages() and extract_iter_to_sg() in the networking code
recvmsg() path until after the merge.
David
next prev parent reply other threads:[~2023-07-05 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 18:02 [syzbot] [crypto?] WARNING in extract_iter_to_sg syzbot
2023-07-05 22:00 ` Herbert Xu
2023-07-05 23:06 ` David Howells [this message]
2023-07-05 23:10 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1869452.1688598362@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+f2c120b449b209d89efa@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).