From: Robert Olsson <robert@robur.slu.se>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Robert Olsson <robert.olsson@its.uu.se>
Subject: [PATCH] pktgen: fix multiple queue warning
Date: Sat, 8 Nov 2008 12:29:32 +0100 [thread overview]
Message-ID: <18709.30748.784246.990265@robur.slu.se> (raw)
In-Reply-To: <20081028193042.22781.15774.stgit@gitlost.lost>
Jeff Kirsher writes:
> - if (ntxq <= num_online_cpus() && (pkt_dev->flags & F_QUEUE_MAP_CPU)) {
> + if (ntxq > num_online_cpus() && (pkt_dev->flags & F_QUEUE_MAP_CPU)) {
> printk(KERN_WARNING "pktgen: WARNING: QUEUE_MAP_CPU "
> - "disabled because CPU count (%d) exceeds number ",
> - num_online_cpus());
> - printk(KERN_WARNING "pktgen: WARNING: of tx queues "
> - "(%d) on %s \n", ntxq, pkt_dev->odev->name);
Jeff,
This triggers with the niu driver which has 12 TX queues on our 8 CPU-core
system. Might be best to make sure that pkt_dev->cur_queue_map never exceeds
ntxq.
pkt_dev->cur_queue_map = pkt_dev->cur_queue_map % pkt_dev->odev->real_num_tx_queues;
Cheers.
--ro
next prev parent reply other threads:[~2008-11-08 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 19:30 [PATCH] pktgen: fix multiple queue warning Jeff Kirsher
2008-10-28 20:10 ` Robert Olsson
2008-10-28 20:22 ` David Miller
2008-10-28 20:22 ` David Miller
2008-11-08 11:29 ` Robert Olsson [this message]
2008-11-17 7:30 ` David Miller
2008-11-17 8:59 ` Robert Olsson
2008-11-19 22:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18709.30748.784246.990265@robur.slu.se \
--to=robert@robur.slu.se \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).