From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE37C10F13 for ; Mon, 8 Apr 2019 21:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81CE120880 for ; Mon, 8 Apr 2019 21:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kd/v1ZF+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbfDHVRq (ORCPT ); Mon, 8 Apr 2019 17:17:46 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35929 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfDHVRq (ORCPT ); Mon, 8 Apr 2019 17:17:46 -0400 Received: by mail-pg1-f196.google.com with SMTP id 85so8011570pgc.3 for ; Mon, 08 Apr 2019 14:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MUgbpqIFGehEkiNV/6uyPJAnay2QPevb2rDCt4DFfUY=; b=kd/v1ZF+dEPODmAJ5x6Z2fOMUNWWXXje6XjyhlwfM+EMG4r4aLDIUgaA5ueF8yVYgx Cqx69QAkxmH0K+eoU4hOf8CymNsgUTcX4YBfFAzQ7clP6dT6xWITXm5RVbtX8osMPaBe oIDgek2px+oaDw9y+m54G3pZIhG8larMZwCV6mVNSklXgxzw/9D4mrzFlUsfXk+YxpCG y71n0Z6/5BuLPD4GHiAQ3uWiIYeXWJNtztSDrI+xkGRjne0tQXH0NpuXXUC4O4G2OTcH 0MoDhMLDMwwE5r+UaGXVZRJH+9NrmKILN72/0ciTSN7l33UjLub4FzKYMmgDbSgwhyUx joFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MUgbpqIFGehEkiNV/6uyPJAnay2QPevb2rDCt4DFfUY=; b=VY/hj424I5BXLajDvG6dDxM11Sh8x3DDlT2es6vqKz1bSauJ/21CdX7GZlfNnY/j5M lsN2F65s3EOJE5iy7CVN0pt/+VsMrhNP4C3Lc5peLln4P3AnKe3CqNOY5yPNvtLLRkcO dmLcS2xWJqvSsJtutPT3UzwLsRwM9k0eYOgY74eeWiwnPVP5WKlMPFH8OthEEoFV2/67 nbqvEv3AjeDrNTB36hfoWc4Ao7MiDtnI7umIuytdlswPhgcZrmZRSo87oaDSRvlEAQAi GH8Oq7MB3XEJtZ0bnSBymNHQye12WHnCj72Pl2INvTMRNsxdwEM6oOobZQmbEoORnQzA +iuQ== X-Gm-Message-State: APjAAAXBa1EUge4rughsNnFEuz4zCGXK8e4zfhBKiWmShVmu4O1HER2I N7E0AE0xj7iFptw7PSqx6OY= X-Google-Smtp-Source: APXvYqwCEAQLJOZfq9Z7Zsv83nfrGXwc5a4yEJmYo+w+FUKri0nP7kKhVYvhnlcAolAEd6y2WVWiOg== X-Received: by 2002:a62:7549:: with SMTP id q70mr22189279pfc.112.1554758265609; Mon, 08 Apr 2019 14:17:45 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id n21sm42519758pfb.42.2019.04.08.14.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 14:17:44 -0700 (PDT) Subject: Re: [PATCH net-next 5/5] Revert: "net: sched: put back q.qlen into a single location" To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S. Miller" , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Eric Dumazet , Ivan Vecera References: <033147df6656a912ba311184e55916333b3745b1.1554740883.git.pabeni@redhat.com> From: Eric Dumazet Message-ID: <1871d6ac-cb83-69a5-608c-d944fa93b315@gmail.com> Date: Mon, 8 Apr 2019 14:17:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <033147df6656a912ba311184e55916333b3745b1.1554740883.git.pabeni@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/08/2019 09:35 AM, Paolo Abeni wrote: > This revert commit 46b1c18f9deb ("net: sched: put back q.qlen > into a single location"). > After the previous patch nobody accesses directly qlen for a child > qdisc when such qdisc does per CPU stats accounting. > In the control path nobody uses directly qlen since commit > 677f1bc207c ("net: sched: introduce and use qdisc tree flush/purge > helpers"), so we can remove the contented atomic ops from the > datapath. > Have you tested HTB with a pfifo_fast on a throttled class ? I do not see any changes in HTB in your patch series, so it is not clear why your patch series is not adding back the issue.