2.6: rxrpc compile errors with SYSCTL=n

2.6: rxrpc compile errors with SYSCTL=n

[Adrian Bunk]

I'm getting tons of the following compile errors in 2.6.8-rc4-mm1 (but 
it doesn't seem to be specific to -mm) with CONFIG_SYSCTL=n:

<--  snip  -->

...
  LD      .tmp_vmlinux1
net/built-in.o(.text+0x154127): In function `__rxrpc_call_acks_timeout':
: undefined reference to `rxrpc_kdebug'
net/built-in.o(.text+0x154167): In function `__rxrpc_call_rcv_timeout':
: undefined reference to `rxrpc_kdebug'
net/built-in.o(.text+0x1541a7): In function `__rxrpc_call_ackr_timeout':
: undefined reference to `rxrpc_kdebug'
net/built-in.o(.text+0x15421e): In function `rxrpc_create_call':
: undefined reference to `rxrpc_ktrace'
net/built-in.o(.text+0x154242): In function `rxrpc_create_call':
: undefined reference to `rxrpc_ktrace'
net/built-in.o(.text+0x154272): In function `rxrpc_create_call':
: undefined reference to `rxrpc_ktrace'
...
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6: rxrpc compile errors with SYSCTL=n

[William Lee Irwin III]

On Thu, Aug 12, 2004 at 12:32:25AM +0200, Adrian Bunk wrote:
> I'm getting tons of the following compile errors in 2.6.8-rc4-mm1 (but 
> it doesn't seem to be specific to -mm) with CONFIG_SYSCTL=n:
> <--  snip  -->
> ...
>   LD      .tmp_vmlinux1
> net/built-in.o(.text+0x154127): In function `__rxrpc_call_acks_timeout':
> : undefined reference to `rxrpc_kdebug'
> net/built-in.o(.text+0x154167): In function `__rxrpc_call_rcv_timeout':
> : undefined reference to `rxrpc_kdebug'

Does this help?


Index: mm1-2.6.8-rc4/include/rxrpc/rxrpc.h
===================================================================
--- mm1-2.6.8-rc4.orig/include/rxrpc/rxrpc.h	2004-08-11 15:27:56.589237088 -0700
+++ mm1-2.6.8-rc4/include/rxrpc/rxrpc.h	2004-08-11 15:28:12.496818768 -0700
@@ -16,10 +16,17 @@
 
 extern uint32_t rxrpc_epoch;
 
+#ifdef CONFIG_SYSCTL
 extern int rxrpc_ktrace;
 extern int rxrpc_kdebug;
 extern int rxrpc_kproto;
 extern int rxrpc_knet;
+#else
+#define rxrpc_ktrace	0
+#define rxrpc_kdebug	0
+#define rxrpc_kproto	0
+#define rxrpc_knet	0
+#endif
 
 extern int rxrpc_sysctl_init(void);
 extern void rxrpc_sysctl_cleanup(void);

Re: 2.6: rxrpc compile errors with SYSCTL=n

[Adrian Bunk]

On Wed, Aug 11, 2004 at 03:41:02PM -0700, William Lee Irwin III wrote:
> On Thu, Aug 12, 2004 at 12:32:25AM +0200, Adrian Bunk wrote:
> > I'm getting tons of the following compile errors in 2.6.8-rc4-mm1 (but 
> > it doesn't seem to be specific to -mm) with CONFIG_SYSCTL=n:
> > <--  snip  -->
> > ...
> >   LD      .tmp_vmlinux1
> > net/built-in.o(.text+0x154127): In function `__rxrpc_call_acks_timeout':
> > : undefined reference to `rxrpc_kdebug'
> > net/built-in.o(.text+0x154167): In function `__rxrpc_call_rcv_timeout':
> > : undefined reference to `rxrpc_kdebug'
> 
> Does this help?
>...

Yes.

Thanks for the quick patch!

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6: rxrpc compile errors with SYSCTL=n

[David Howells]

> > I'm getting tons of the following compile errors in 2.6.8-rc4-mm1 (but 
> > it doesn't seem to be specific to -mm) with CONFIG_SYSCTL=n:
> ...
> Does this help?

Yeah... that patch will do. Thanks. Pass it to Andrew?

David