From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up
Date: Sat, 24 Sep 2016 10:45:14 +0200 [thread overview]
Message-ID: <1876960.mYVMvaW4Lo@wuerfel> (raw)
In-Reply-To: <1474694662-7527-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 1:24:22 PM CEST Baoyou Xie wrote:
> }
>
> -extern int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs);
> extern void modehscx(struct BCState *bcs, int mode, int bc);
> extern void hscx_l2l1(struct PStack *st, int pr, void *arg);
>
The change makes sense, but I would remove the other two declarations
as well, as extern declarations don't belong into .c files.
As far as I can tell, modehscx() already has a declaration in hscx.h,
while hscx_l2l1() doesn't, and the declaration here should be
moved as well.
> diff --git a/drivers/isdn/hisax/hscx.h b/drivers/isdn/hisax/hscx.h
> index 1148b4b..fa7bf16 100644
> --- a/drivers/isdn/hisax/hscx.h
> +++ b/drivers/isdn/hisax/hscx.h
> @@ -39,3 +39,4 @@ extern void modehscx(struct BCState *bcs, int mode, int bc);
> extern void clear_pending_hscx_ints(struct IsdnCardState *cs);
> extern void inithscx(struct IsdnCardState *cs);
> extern void inithscxisac(struct IsdnCardState *cs, int part);
> +int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs);
For consistency, I would add 'extern' here. We normally leave that out,
but I think if there are lots of declarations in a header file that all
have it, it's better if they are all the same.
Arnd
next prev parent reply other threads:[~2016-09-24 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 5:24 [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Baoyou Xie
2016-09-24 8:45 ` Arnd Bergmann [this message]
2016-09-24 14:17 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1876960.mYVMvaW4Lo@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).