From: Paul Mackerras <paulus@samba.org>
To: David Miller <davem@davemloft.net>
Cc: gorcunov@gmail.com, akpm@linux-foundation.org,
jchapman@katalix.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ppp_generic - fix broken userspace
Date: Sun, 11 Jan 2009 21:29:49 +1100 [thread overview]
Message-ID: <18793.51741.28374.460500@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20090110.233503.222465267.davem@davemloft.net>
David Miller writes:
> PPP was converted to use IDR instead of PPP's duplicate
> implementation.
>
> A bug was introduced in that conversion, and that bug is being fixed
> here.
>
> What is not to like? :-)
Ah OK, that sounds all right. I was reacting to the "broken
userspace" in the patch description which at first glance seemed to be
saying that userspace (i.e. pppd :) is doing something which has
recently been declared to be wrong and therefore it is "broken".
I think "fix broken userspace" as a patch headline is quite
ambiguous. Something like "Fix bug in conversion to use IDR" would be
more informative.
Paul.
next prev parent reply other threads:[~2009-01-11 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 20:28 [PATCH] net: ppp_generic - fix broken userspace Cyrill Gorcunov
2009-01-10 20:31 ` Cyrill Gorcunov
2009-01-11 0:31 ` Paul Mackerras
2009-01-11 7:32 ` Cyrill Gorcunov
2009-01-11 7:35 ` David Miller
2009-01-11 10:29 ` Paul Mackerras [this message]
2009-01-11 11:45 ` Cyrill Gorcunov
2009-01-13 6:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18793.51741.28374.460500@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gorcunov@gmail.com \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).