Re: [STABLE][3.0][3.2][Add PATCH] phy/fixed: use an unique MDIO bus name

Re: [STABLE][3.0][3.2][Add PATCH] phy/fixed: use an unique MDIO bus name

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

On Fri, 2012-10-05 at 08:59 -0400, Steven Rostedt wrote:
> I started testing my 3.2-rt branch on a powerpc box and it would
> constantly spit out the following warning causing ktest to think the
> boot failed:
> 
> sysfs: cannot create duplicate filename '/class/mdio_bus/0
[...]
> Doing some investigations, I found it only triggered on some configs,
> and it was fixed by 3.3. I ran a ktest.pl reverse bisect (bad is good
> and good is bad) and it ended on this commit:
> 
> commit 9e6c643bb4502c50b6511206601b7760c610dfcc
> Author: Florian Fainelli <florian@openwrt.org>
> Date:   Mon Jan 9 23:59:25 2012 +0000
> 
>     phy/fixed: use an unique MDIO bus name.
>     
>     Signed-off-by: Florian Fainelli <florian@openwrt.org>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
> index 1fa4d73..633680d 100644
> --- a/drivers/net/phy/fixed.c
> +++ b/drivers/net/phy/fixed.c
> @@ -220,7 +220,7 @@ static int __init fixed_mdio_bus_init(void)
>                 goto err_mdiobus_reg;
>         }
>  
> -       snprintf(fmb->mii_bus->id, MII_BUS_ID_SIZE, "0");
> +       snprintf(fmb->mii_bus->id, MII_BUS_ID_SIZE, "fixed-0");
>         fmb->mii_bus->name = "Fixed MDIO Bus";
>         fmb->mii_bus->priv = fmb;
>         fmb->mii_bus->parent = &pdev->dev;
> 
> Sure enough, adding this patch to both 3.2 and 3.0 fixed the bug.
> 
> Please pull this patch into the 3.2 and 3.0 stable trees.

Networking stable fixes are normally vetted, backported and bundled up
by David, so I'll let him decide on this.

There are a lot more MDIO bus drivers that don't play nicely with
others, most of which seem to be fixed in mainline.  If David agrees
that these are generally worthwhile then perhaps someone could try to
gather those up?

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [STABLE][3.0][3.2][Add PATCH] phy/fixed: use an unique MDIO bus name

[David Miller]

From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 07 Oct 2012 16:33:39 +0100

> Networking stable fixes are normally vetted, backported and bundled up
> by David, so I'll let him decide on this.
> 
> There are a lot more MDIO bus drivers that don't play nicely with
> others, most of which seem to be fixed in mainline.  If David agrees
> that these are generally worthwhile then perhaps someone could try to
> gather those up?

I very much am not inclined to backport this stuff, it impacts
an extremely small group of people so the risk/benefit ratio is
simply not worth it for me to do the work.

If someone else does the work and tests it, I'm willing to ACK
it going into -stable.

But this change impacted a lot of MDIO drivers and there were
regressions that needed to be fixed up the first time this stuff
went in.

Re: [STABLE][3.0][3.2][Add PATCH] phy/fixed: use an unique MDIO bus name

[Steven Rostedt]

On Sun, 2012-10-07 at 14:56 -0400, David Miller wrote:

> But this change impacted a lot of MDIO drivers and there were
> regressions that needed to be fixed up the first time this stuff
> went in.

If it's that big of a deal then we can forget about this fix. I can get
around it if I tweak my config. Probably just skip the MDIO stuff.

-- Steve

Re: [STABLE][3.0][3.2][Add PATCH] phy/fixed: use an unique MDIO bus name

[Florian Fainelli]

On Monday 08 October 2012 08:39:14 Steven Rostedt wrote:
> On Sun, 2012-10-07 at 14:56 -0400, David Miller wrote:
> 
> > But this change impacted a lot of MDIO drivers and there were
> > regressions that needed to be fixed up the first time this stuff
> > went in.
> 
> If it's that big of a deal then we can forget about this fix. I can get
> around it if I tweak my config. Probably just skip the MDIO stuff.

Yes, I think you can just drop the change considering the number of depending 
commits.
--
Florian