From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40ED7C282DD for ; Wed, 8 Jan 2020 19:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2139920705 for ; Wed, 8 Jan 2020 19:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727917AbgAHTOj (ORCPT ); Wed, 8 Jan 2020 14:14:39 -0500 Received: from mga04.intel.com ([192.55.52.120]:45236 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgAHTOi (ORCPT ); Wed, 8 Jan 2020 14:14:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 11:14:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,411,1571727600"; d="scan'208";a="211639519" Received: from jekeller-mobl.amr.corp.intel.com (HELO [134.134.177.84]) ([134.134.177.84]) by orsmga007.jf.intel.com with ESMTP; 08 Jan 2020 11:14:38 -0800 Subject: Re: FW: [question] About triggering a region snapshot through the devlink cmd To: Alex Vesker Cc: davem@davemloft.net, Jiri Pirko , linuxarm@huawei.com, linyunsheng@huawei.com, netdev@vger.kernel.org, Jiri Pirko References: <02874ECE860811409154E81DA85FBB58B26FA36F@fmsmsx101.amr.corp.intel.com> From: Jacob Keller Organization: Intel Corporation Message-ID: <18867ab8-6200-20c6-6ce0-8c123609622f@intel.com> Date: Wed, 8 Jan 2020 11:14:38 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/8/2020 4:15 AM, Alex Vesker wrote: > I am a biased here but, devlink trigger can be useful... I am not aware > of other alternatives, > devlink health has it`s benefits but it is not devlink region. If you > will decide to implement I can > review the design, if Jiri is ok with the idea. > Sure. I am not quite sure how long it will be till patches are on the list, as I'm currently in the process of implementing devlink support for one of the Intel drivers, and would be using that driver as an example. Actually, come to think of it, I may just implement the region trigger and use netdevsim as the example. That should enable those patches to hit the list sooner than the patches for implementing devlink for the ice driver. I will Cc you for review when I send those patches. Thanks, Jake