From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Vladimir Oltean'" <vladimir.oltean@nxp.com>,
"'Martin K. Petersen'" <martin.petersen@oracle.com>
Cc: <linux-phy@lists.infradead.org>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Neil Armstrong'" <neil.armstrong@linaro.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <linux-can@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-riscv@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-sunxi@lists.linux.dev>, <linux-tegra@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
<spacemit@lists.linux.dev>, <UNGLinuxDriver@microchip.com>,
"'Bart Van Assche'" <bvanassche@acm.org>,
"'Peter Griffin'" <peter.griffin@linaro.org>,
"'James E.J. Bottomley'" <James.Bottomley@HansenPartnership.com>,
"'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Chanho Park'" <chanho61.park@samsung.com>
Subject: RE: [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into struct phy guts
Date: Mon, 23 Mar 2026 18:05:36 +0530 [thread overview]
Message-ID: <1891546521.01774280282025.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: <20260323115848.ghdu4sbk75tvggfb@skbuf>
Hi Vladimir
> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> Sent: Monday, March 23, 2026 5:29 PM
> To: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>; Neil
> Armstrong <neil.armstrong@linaro.org>; dri-devel@lists.freedesktop.org;
> freedreno@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org;
> linux-arm-msm@vger.kernel.org; linux-can@vger.kernel.org; linux-
> gpio@vger.kernel.org; linux-ide@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-media@vger.kernel.org; linux-
> pci@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-
> riscv@lists.infradead.org; linux-rockchip@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org; linux-scsi@vger.kernel.org;
linux-sunxi@lists.linux.dev;
> linux-tegra@vger.kernel.org; linux-usb@vger.kernel.org;
> netdev@vger.kernel.org; spacemit@lists.linux.dev;
> UNGLinuxDriver@microchip.com; Bart Van Assche <bvanassche@acm.org>;
> Alim Akhtar <alim.akhtar@samsung.com>; Peter Griffin
> <peter.griffin@linaro.org>; James E.J. Bottomley
> <James.Bottomley@HansenPartnership.com>; Krzysztof Kozlowski
> <krzk@kernel.org>; Chanho Park <chanho61.park@samsung.com>
> Subject: Re: [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into
> struct phy guts
>
> On Thu, Mar 19, 2026 at 10:15:17PM -0400, Martin K. Petersen wrote:
> > Vladimir,
> >
> > > The Exynos host controller driver is clearly a PHY consumer (gets
> > > the
> > > ufs->phy using devm_phy_get()), but pokes into the guts of struct
> > > ufs->phy
> > > to get the generic_phy->power_count.
> >
> > Ah, newer version. Would still like an ack from Samsung.
> >
> > And I hit the wrong key, I did not actually apply this...
>
> I will have to resend v6 because of an armv7 build error I've caused for
ufs-
> qcom.c (which doesn't #include <linux/interrupt.h>, and relies on a
transitive
> inclusion from <linux/phy/phy.h>). It would be nice to get the ack from
> Samsung, but I'll send the next version in the upcoming hours regardless.
Will review and possibly test on one of the board later tonight
next prev parent reply other threads:[~2026-03-23 15:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:32 [PATCH v5 phy-next 00/27] Split Generic PHY consumer and provider API Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 01/27] ata: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 02/27] PCI: Add missing headers transitively included by <linux/phy/phy.h> Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 03/27] usb: add " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 04/27] drm: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 05/27] phy: " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 06/27] phy: spacemit: include missing <linux/phy/phy.h> Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 07/27] net: lan969x: include missing <linux/of.h> Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 08/27] PCI: Remove device links to PHY Vladimir Oltean
2026-03-24 5:35 ` Manivannan Sadhasivam
2026-03-19 22:32 ` [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into struct phy guts Vladimir Oltean
2026-03-20 2:15 ` Martin K. Petersen
2026-03-20 8:22 ` Vladimir Oltean
2026-03-23 11:58 ` Vladimir Oltean
2026-03-23 12:35 ` Alim Akhtar [this message]
2026-03-23 22:41 ` Vladimir Oltean
2026-03-23 17:26 ` Alim Akhtar
2026-03-19 22:32 ` [PATCH v5 phy-next 10/27] scsi: ufs: qcom: keep parallel track of PHY power state Vladimir Oltean
2026-03-24 5:30 ` Manivannan Sadhasivam
2026-03-25 11:43 ` Vladimir Oltean
2026-03-25 11:51 ` Manivannan Sadhasivam
2026-03-25 11:57 ` Vladimir Oltean
2026-03-26 8:04 ` Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 11/27] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 12/27] usb: host: tegra: " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 13/27] usb: gadget: tegra-xudc: " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 14/27] drm/msm/dp: remove debugging prints with internal struct phy state Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 15/27] phy: move provider API out of public <linux/phy/phy.h> Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 16/27] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 17/27] phy: introduce phy_get_max_link_rate() helper for consumers Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 18/27] drm/rockchip: dsi: include PHY provider header Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 19/27] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 20/27] media: sunxi: a83-mips-csi2: include PHY provider header Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 21/27] net: renesas: rswitch: " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 22/27] pinctrl: tegra-xusb: " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 23/27] power: supply: cpcap-charger: include missing <linux/property.h> Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 24/27] phy: include PHY provider header (1/2) Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 25/27] phy: include PHY provider header (2/2) Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 26/27] phy: remove temporary provider compatibility from consumer header Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 27/27] MAINTAINERS: add regexes for linux-phy Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01774280282025.JavaMail.epsvc@epcpadp2new \
--to=alim.akhtar@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bvanassche@acm.org \
--cc=chanho61.park@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox