Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP

[Mateusz Polchlopek <mateusz.polchlopek@intel.com>]

On 5/29/2024 1:54 AM, Keller, Jacob E wrote:
> 
> 
>> -----Original Message-----
>> From: Jakub Kicinski <kuba@kernel.org>
>> Sent: Tuesday, May 28, 2024 1:01 PM
>> To: Polchlopek, Mateusz <mateusz.polchlopek@intel.com>
>> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Keller, Jacob E
>> <jacob.e.keller@intel.com>; Drewek, Wojciech <wojciech.drewek@intel.com>;
>> Rahul Rameshbabu <rrameshbabu@nvidia.com>
>> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
>> SIOCSHWTSTAMP and SIOCGHWTSTAMP
>>
>> On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
>>> +	.ndo_eth_ioctl		= iavf_do_ioctl,
>>
>> Please use the new ndos:
>>
>>   * int (*ndo_hwtstamp_get)(struct net_device *dev,
>>   *			   struct kernel_hwtstamp_config *kernel_config);
>>   *	Get the currently configured hardware timestamping parameters for the
>>   *	NIC device.
>>   *
>>   * int (*ndo_hwtstamp_set)(struct net_device *dev,
>>   *			   struct kernel_hwtstamp_config *kernel_config,
>>   *			   struct netlink_ext_ack *extack);
>>   *	Change the hardware timestamping parameters for NIC device.
> 
> +1, this is an excellent cleanup.
> 
> Thanks,
> Jake

Hmmm... sounds good :) Thanks for pointing that, I will take a look
and will try to prepare solution in next version