From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD70C38A02 for ; Fri, 28 Oct 2022 13:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiJ1N5r (ORCPT ); Fri, 28 Oct 2022 09:57:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbiJ1N5q (ORCPT ); Fri, 28 Oct 2022 09:57:46 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF6A1D52F8; Fri, 28 Oct 2022 06:57:45 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id f23so4916004plr.6; Fri, 28 Oct 2022 06:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pURq2ZAIigLcDR9TJTtusCVtDsz7Ut0rfG8GHdRJiLY=; b=HOgEVO+N1Zf1fQolQQp13J5kNAlNn8KlHrL0Sg5RBszVJCST6gOzhLjEA1+izYlRo0 wKLRzpzzb3OVrRcCE2as6vKT3PzVSgpdYdxiRJ7KNfZbB5obteL03PnlBB8YaxZ5x0le ARJEhl1HFQb4677BmbF40X6pHBAHjcvpZgb2D0VTCX3uxTlJ2zLIIkJSwK9JDINnx33K NE6d7/2o9zRNVdvM8mfo/gdwUG4lMayDxZ5/OcI/dKOu5MUgVyhy9ziGHqCWuy1X5nzB svIxyAdmMuk3v3rl24T9lIR/NtCgvNXJ+wWuKin3nFQNSsYTHtq835J+IxRFqlS4lJXq gDZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pURq2ZAIigLcDR9TJTtusCVtDsz7Ut0rfG8GHdRJiLY=; b=YbHS7watV1dJGJ/Eub8+D+QgZTF52/vNjNWnJVHTZoQntkEYhEJn4fjCDoFp2axBsp Ri1i+kUBaqk70cQfhGjhnTCp2Cpisuxyi+QLt6GH/+VPrweH+aKaRN4AadcgXUyVQffv 68Bz8YcvPQ36eIH3o8gb/uV5iqelVZi13ZbxczMFYpmnssCWMgLdTfyfKLKKoo+H7NFc lMNX6WzWiQNUJ58BA5VgNHusBNe3Wn1b2IP/EyNf7kqVisEBLdUj+Ep4SSsw5Cc6qglE 5nghFetoEWHKhKbBacsoyMwItpQ/1LjBtSSrEAeiXLj2kM2+nfA+ct7fIskBsCqbQbHA X0SQ== X-Gm-Message-State: ACrzQf1dYXE1Xy37a2pdsHBYWvJBHO6sZxLF5gw5MiI/frFH0EGpojSh mBDtWTeuoCwlqALn+hnx7S8= X-Google-Smtp-Source: AMsMyM4TmHqsO8JBZiWG9JydskJ3G+0iWR4RBrx4gAFd8i7wP2pvDVtrfXUd4cIl1xJm5O4PcntkPg== X-Received: by 2002:a17:902:e84e:b0:186:b699:d4ab with SMTP id t14-20020a170902e84e00b00186b699d4abmr23303128plg.116.1666965465198; Fri, 28 Oct 2022 06:57:45 -0700 (PDT) Received: from [192.168.43.80] (subs03-180-214-233-72.three.co.id. [180.214.233.72]) by smtp.gmail.com with ESMTPSA id n3-20020a635c43000000b0045935b12e97sm2734731pgm.36.2022.10.28.06.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 06:57:44 -0700 (PDT) Message-ID: <18fe94a5-23f3-aa59-ddf3-d9f0cd370182@gmail.com> Date: Fri, 28 Oct 2022 20:57:38 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 12/15] drivers: net: slip: remove SLIP_MAGIC Content-Language: en-US To: =?UTF-8?B?0L3QsNCx?= Cc: Jonathan Corbet , Federico Vaga , Alex Shi , Yanteng Si , Hu Haowen , "David S. Miller" , Eric Dumazet , =?UTF-8?Q?Jakub_Kici=c5=84ski?= , Paolo Abeni , Greg Kroah-Hartman , Jiri Slaby , Marc Kleine-Budde , Oliver Hartkopp , Sebastian Andrzej Siewior , Duoming Zhou , Huang Pei , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc-tw-discuss@lists.sourceforge.net, netdev@vger.kernel.org References: <9a453437b5c3b4b1887c1bd84455b0cc3d1c40b2.1666822928.git.nabijaczleweli@nabijaczleweli.xyz> From: Bagas Sanjaya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/27/22 05:43, наб wrote: > We have largely moved away from this approach, > and we have better debugging instrumentation nowadays: kill it > > Additionally, all SLIP_MAGIC checks just early-exit instead > of noting the bug, so they're detrimental, if anything > Same reply as [1]. [1]: https://lore.kernel.org/linux-doc/9386b19f-dd99-3601-9e87-3056100dfe53@gmail.com/ -- An old man doll... just what I always wanted! - Clara