From: robert@herjulf.net
To: Joe Perches <joe@perches.com>
Cc: Robert Olsson <robert@herjulf.net>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: Diagnostic Monitoring Interface Monitoring (DOM) PATCH 4/5 for net-next-2.6
Date: Tue, 24 Nov 2009 19:12:38 +0100 [thread overview]
Message-ID: <19212.8726.367568.937773@gargle.gargle.HOWL> (raw)
In-Reply-To: <1259017659.16503.138.camel@Joe-Laptop.home>
Joe Perches writes:
> Can you run ./scripts/checkpatch.pl on your patches please?
Yes there were many objections... but my linux quantum is for over for now
> > + if((res = read_phy_diag(hw, 0x1, DOM_A2_TEMP_SLOPE, &pd->temp_slope)))
> > + goto out;
> [etc...]
> > + if((res = read_phy_diag(hw, 0x1, DOM_A2_TX_I_OFFSET, &pd->tx_bias_offset)))
> > + goto out;
>
> perhaps this is clearer as:
>
> if (read_phy_diag(hw, 0x1, reg, loc) ||
> read_phy_diag(hw, 0x1, reg2, loc2) ||
> ...
> read_phy_diag(hw, 0x1, regN, locN))
> goto out;
Feel free to attack it...
Cheers
--ro
next prev parent reply other threads:[~2009-11-24 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 22:55 Diagnostic Monitoring Interface Monitoring (DOM) PATCH 4/5 for net-next-2.6 Robert Olsson
2009-11-23 23:07 ` Joe Perches
2009-11-24 18:12 ` robert [this message]
2009-11-25 3:57 ` [PATCH net-next-2.6] igb and ixgbe: DOM support cleanups Joe Perches
2009-11-25 4:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19212.8726.367568.937773@gargle.gargle.HOWL \
--to=robert@herjulf.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox