From: Tom St Denis <tstdenis@elliptictech.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Borislav Petkov <bp@alien8.de>,
Eric Dumazet <erdnetdev@gmail.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
David Miller <davem@davemloft.net>,
steffen klassert <steffen.klassert@secunet.com>,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
Mike Galbraith <bitbucket@online.de>
Subject: Re: IPsec AH use of ahash
Date: Sun, 20 Jan 2013 19:47:57 -0500 (EST) [thread overview]
Message-ID: <1926711985.94035.1358729277262.JavaMail.root@elliptictech.com> (raw)
In-Reply-To: <20130120220721.GA5434@home.goodmis.org>
----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Tom St Denis" <tstdenis@elliptictech.com>
> Cc: "Borislav Petkov" <bp@alien8.de>, "Eric Dumazet" <erdnetdev@gmail.com>, "Waskiewicz Jr, Peter P"
> <peter.p.waskiewicz.jr@intel.com>, "David Miller" <davem@davemloft.net>, "steffen klassert"
> <steffen.klassert@secunet.com>, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
> "Michal Kubecek" <mkubecek@suse.cz>, "Mike Galbraith" <bitbucket@online.de>
> Sent: Sunday, 20 January, 2013 5:07:22 PM
> Subject: Re: IPsec AH use of ahash
>
> On Sun, Jan 20, 2013 at 07:56:27AM -0500, Tom St Denis wrote:
> >
> > You should really try running checkpatch.pl over code that's
> > already in the kernel before you call out new contributors on it.
> >
> > How is this supposed to not be adversarial when I can't even use
> > the Kernel source itself as a reference?
>
> So there's a lot of crap code in the kernel (that we are trying to
> clean
> up when we have the time... see Kernel Janitors). But that's still no
> excuse to allow more crap code to enter. That means adding more crap
> to
> clean up.
Nowhere in the coding guidelines I've seen thus far says that you have to comment or document your code.
I wouldn't consider fixing "crap" code to mean to change indentation style [unless the original is horrible]. It's pointless busy work at best.
If you want to improve the quality of the code I'd start with /* and end with */ once in a while.
Tom
next prev parent reply other threads:[~2013-01-21 0:47 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528051367.70594.1358268708738.JavaMail.root@elliptictech.com>
2013-01-16 6:21 ` IPsec AH use of ahash Steffen Klassert
2013-01-18 19:35 ` Tom St Denis
2013-01-18 19:50 ` David Miller
2013-01-18 20:53 ` Tom St Denis
2013-01-18 22:16 ` Waskiewicz Jr, Peter P
2013-01-18 22:31 ` Tom St Denis
2013-01-19 2:33 ` Michal Kubecek
2013-01-19 2:59 ` Tom St Denis
2013-01-19 3:59 ` Eric Dumazet
2013-01-19 10:30 ` Tom St Denis
2013-01-19 15:46 ` Eric Dumazet
2013-01-20 5:06 ` Mike Galbraith
2013-01-20 10:31 ` Borislav Petkov
2013-01-20 12:56 ` Tom St Denis
2013-01-20 13:34 ` Alexander Holler
2013-01-20 13:54 ` Tom St Denis
2013-01-30 22:16 ` Jan Engelhardt
2013-01-20 22:07 ` Steven Rostedt
2013-01-21 0:47 ` Tom St Denis [this message]
2013-01-20 12:55 ` Tom St Denis
2013-01-20 14:11 ` Mike Galbraith
2013-01-20 15:07 ` Tom St Denis
2013-01-20 16:34 ` David Dillow
2013-01-20 17:40 ` Tom St Denis
2013-01-20 18:11 ` David Dillow
2013-01-20 18:47 ` Tom St Denis
2013-01-20 22:54 ` Steven Rostedt
2013-01-21 0:34 ` Borislav Petkov
2013-01-21 0:40 ` Tom St Denis
2013-01-21 1:08 ` Borislav Petkov
2013-01-21 9:18 ` David Dillow
2013-01-21 10:20 ` Tom St Denis
2013-01-21 13:38 ` Steven Rostedt
2013-01-21 13:45 ` Tom St Denis
2013-01-21 14:37 ` Steven Rostedt
2013-01-21 14:51 ` Tom St Denis
2013-01-21 15:28 ` Steven Rostedt
2013-01-21 15:31 ` Tom St Denis
2013-01-21 15:49 ` Chris Friesen
2013-01-21 16:05 ` Tom St Denis
2013-01-20 20:30 ` Alan Cox
2013-01-21 0:46 ` Tom St Denis
2013-01-20 17:03 ` H. Peter Anvin
2013-01-20 17:33 ` Tom St Denis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1926711985.94035.1358729277262.JavaMail.root@elliptictech.com \
--to=tstdenis@elliptictech.com \
--cc=bitbucket@online.de \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=erdnetdev@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rostedt@goodmis.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).