From: Doug Maxey <dwm@enoyolf.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Doug Maxey <dwm@austin.ibm.com>,
Linux PowerPC List <linuxppc-dev@ozlabs.org>,
Jan-Bernd Themann <themann@de.ibm.com>,
Jeff Garzik <jgarzik@garzik.org>,
Paul Mackerras <paulus@samba.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints
Date: Fri, 01 Feb 2008 22:39:57 -0600 [thread overview]
Message-ID: <19294.1201927197@bebe.enoyolf.org> (raw)
In-Reply-To: <20080201192344.GA4541@loki.buserror.net>
On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote:
> On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:
> > /* input param R5 */
> > -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
...
> > +#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
...
>
> This was better the way it was (before, it was readable at any tab setting);
> checkpatch is overeager to complain on tab/space issues (it's a bit hard to
> distinguish indentation from alignment with a regex).
In emacs, with no special offsets, the lines appear to still line up.
What did happen was spaces were turned to tabs where applicable.
What editor shows a bad alignment?
++doug
next prev parent reply other threads:[~2008-02-02 4:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 2:20 [PATCH 0/5] ehea checkpatch fixups Doug Maxey
2008-02-01 2:20 ` [PATCH 1/5] ehea: fix ehea.h checkpatch complaints Doug Maxey
2008-02-01 18:40 ` Jeff Garzik
2008-02-01 18:43 ` Jeff Garzik
2008-02-01 2:20 ` [PATCH 2/5] ehea: fix ethtool " Doug Maxey
2008-02-01 2:20 ` [PATCH 3/5] ehea: fix main " Doug Maxey
2008-02-01 2:20 ` [PATCH 4/5] ehea: fix phyp " Doug Maxey
2008-02-01 19:23 ` Scott Wood
2008-02-02 4:39 ` Doug Maxey [this message]
2008-02-04 18:06 ` Scott Wood
2008-02-01 2:20 ` [PATCH 5/5] ehea: fix qmr " Doug Maxey
2008-02-01 3:05 ` [PATCH 0/5] ehea checkpatch fixups Nathan Lynch
2008-02-01 4:35 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19294.1201927197@bebe.enoyolf.org \
--to=dwm@enoyolf.org \
--cc=dwm@austin.ibm.com \
--cc=jgarzik@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).