* [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP
@ 2024-09-24 9:15 Geert Uytterhoeven
2024-09-24 9:31 ` Heiko Stuebner
2024-09-24 12:16 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-09-24 9:15 UTC (permalink / raw)
To: Marc Kleine-Budde, kernel, Vincent Mailhol
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Heiko Stuebner, linux-can, netdev, linux-arm-kernel,
linux-rockchip, linux-kernel, Geert Uytterhoeven
The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence
add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
driver when configuring a kernel without Rockchip platform support.
Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/can/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig
index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644
--- a/drivers/net/can/rockchip/Kconfig
+++ b/drivers/net/can/rockchip/Kconfig
@@ -3,6 +3,7 @@
config CAN_ROCKCHIP_CANFD
tristate "Rockchip CAN-FD controller"
depends on OF || COMPILE_TEST
+ depends on ARCH_ROCKCHIP || COMPILE_TEST
select CAN_RX_OFFLOAD
help
Say Y here if you want to use CAN-FD controller found on
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP
2024-09-24 9:15 [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP Geert Uytterhoeven
@ 2024-09-24 9:31 ` Heiko Stuebner
2024-09-24 12:16 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2024-09-24 9:31 UTC (permalink / raw)
To: Marc Kleine-Budde, kernel, Vincent Mailhol, Geert Uytterhoeven
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-can, netdev, linux-arm-kernel, linux-rockchip, linux-kernel,
Geert Uytterhoeven
Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven:
> The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence
> add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
> driver when configuring a kernel without Rockchip platform support.
>
> Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
makes a lot of sense, and with the compile-test in, it'll still get
test-build
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/net/can/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig
> index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644
> --- a/drivers/net/can/rockchip/Kconfig
> +++ b/drivers/net/can/rockchip/Kconfig
> @@ -3,6 +3,7 @@
> config CAN_ROCKCHIP_CANFD
> tristate "Rockchip CAN-FD controller"
> depends on OF || COMPILE_TEST
> + depends on ARCH_ROCKCHIP || COMPILE_TEST
> select CAN_RX_OFFLOAD
> help
> Say Y here if you want to use CAN-FD controller found on
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP
2024-09-24 9:15 [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP Geert Uytterhoeven
2024-09-24 9:31 ` Heiko Stuebner
@ 2024-09-24 12:16 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2024-09-24 12:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: kernel, Vincent Mailhol, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Heiko Stuebner, linux-can, netdev,
linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On 24.09.2024 11:15:31, Geert Uytterhoeven wrote:
> The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence
> add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
> driver when configuring a kernel without Rockchip platform support.
>
> Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to linux-can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-24 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 9:15 [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP Geert Uytterhoeven
2024-09-24 9:31 ` Heiko Stuebner
2024-09-24 12:16 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).