From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-b-110.mailbox.org (mout-b-110.mailbox.org [195.10.208.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4937C40861F for ; Wed, 10 Jun 2026 15:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.10.208.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104512; cv=none; b=pPnMZPVrS2YNFycBhSr+4IAEM1ON6sDS9Cu0r0CRcI45JoB/5qm2rDDDtkpAyR03N/KcAuIHRjKFZsG7/8Y4Y72AZKMh57I+D3CFtKC9EQOHaIP79g2grJbIJjSKGRUcgsbJDgIU1SnygpCdh1lHwE9NF4InNAkf6O5wVzxPXUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104512; c=relaxed/simple; bh=AcHnBkODCIJQUsA/TbUO5i7nbvynSvbc5zIJYSN8Wcg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=Uf71Two3NPb777TBLxDNapU+jqlg4gFh89w6l+Q7Z19Yl4kCmMuqfQQAf/YX1+YlHpYMhZprtz/sv5+3w/HDRAz0dkGPZ3XBDhh4gPIWn032piDr8G8Suwiw9Yu7oiyEpN+5Y0fUgESgCKHxJZG/tfB+1HNm8Dsg/9ZghISFasg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mandelbit.com; spf=pass smtp.mailfrom=mandelbit.com; dkim=pass (2048-bit key) header.d=mandelbit.com header.i=@mandelbit.com header.b=BcR5yziy; arc=none smtp.client-ip=195.10.208.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mandelbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mandelbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mandelbit.com header.i=@mandelbit.com header.b="BcR5yziy" Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-110.mailbox.org (Postfix) with ESMTPS id 4gb8Jh16pkz9ydK; Wed, 10 Jun 2026 17:07:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1781104036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8cyTzK8VVLFV0bzqRLOmtBcBa8FWin92OY6w3YNrns=; b=BcR5yziyiahOm5d6mT4ZDwC6XMwDbJjCs+Krg/eRB436DuFFMYmmk5Ep89S78a0g327U3r 2BVNGEeoTFWjukFs0F6pMV9cYkGCJ0KJgpbquEyd96/RCrhLHIEs3iR3Hhxru8+1WGxFTq iWW8hxVi7XELTJXy2huvGyGHPwGy16HncJ8zcP4yhHMm/Z835q4Nc6fCfGX4HMFcQlXzVO 4mP4imMNNjTVj+GUX8pgf+pKU63MuYP0P67OD3EfOTHyk+STgheXKsVI1su4ZqLCSz8AA8 2n07bCdFFuCnIb+WY9cwWYxEpD3eQzWTA5CuX5FqNAVp8XZiAFKDWm4c1pnqWA== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of marco@mandelbit.com designates 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=marco@mandelbit.com Date: Wed, 10 Jun 2026 17:07:12 +0200 (CEST) From: Marco Baffo To: Jakub Kicinski Cc: Antonio Quartulli , netdev@vger.kernel.org, Sabrina Dubroca , Ralf Lici , Paolo Abeni , Andrew Lunn , "David S. Miller" , Eric Dumazet Message-ID: <1932179615.53655.1781104032870@app.mailbox.org> In-Reply-To: <20260610073111.6273e17a@kernel.org> References: <20260608150741.3320919-1-antonio@openvpn.net> <20260608150741.3320919-7-antonio@openvpn.net> <20260609194246.23c66818@kernel.org> <1290464191.15539.1781081055969@app.mailbox.org> <20260610073111.6273e17a@kernel.org> Subject: Re: [PATCH net 6/6] ovpn: use monotonic clock for peer keepalive timeouts Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Rspamd-Queue-Id: 4gb8Jh16pkz9ydK > On 06/10/2026 4:31 PM CEST Jakub Kicinski wrote: > > > On Wed, 10 Jun 2026 10:44:15 +0200 (CEST) Marco Baffo wrote: > > > On Mon, 8 Jun 2026 17:07:37 +0200 Antonio Quartulli wrote: > > > > Replace ktime_get_real_seconds() with the monotonic ktime_get_boottime_seconds() > > > > to ensure the keepalive mechanism is robust against system clock modifications. > > > > > > Why boottime? Unless there's a reason shouldn't we be using > > > plain ktime_get_seconds() which is CLOCK_MONOTONIC? > > > > > > (if you decide to respin could you also drop the selftest change > > > from this PR and move it to net-next? memory leaks in selftests > > > are not important) > > > > Hi Jakub! > > ktime_get_boottime() is like ktime_get() but it does not stop when suspended. > > Worrying about keepalive timeout when system is suspended seems > quite silly, did some AI tool suggest this? Anyway, if you want > to keep this code please improve the commit message. Yes, it was suggested by Sashiko but it does not seems like a bad idea to me anyway, but please tell me if i'm missing something. Regarding the commit message i would be happy to improve it but it looks good to me, do you have any suggestion?