Re: [PATCH net-next v2 5/7] cxgb4: convert to ndo_hwtstamp API

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 15/10/2025 11:05, Simon Horman wrote:
> On Tue, Oct 14, 2025 at 10:42:14PM +0000, Vadim Fedorenko wrote:
>> Convert to use .ndo_hwtstamp_get()/.ndo_hwtstamp_set() callbacks.
>>
>> Though I'm not quite sure it worked properly before the conversion.
>>
>> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> 
> Hi Vadim,
> 
> There is quite a lot of change here. Probably it's not worth "fixing"
> the current code before migrating it. But I think it would be worth
> expanding a bit on the statement about not being sure it worked?

Hi Simon!

Well, let me try to explain the statement about not being sure it
worked. The original code was copying new configuration into netdev's
private structure before validating that the values are acceptable by
the hardware. In case of error, the driver was not restoring original
values, and after the call:

ioctl(SIOCSHWTSTAMP, <unsupported_config>) = -ERANGE

the driver would have configuration which could not be reapplied and not 
synced to the actual hardware config:

ioctl(SIOCGHWTSTAMP) = <unsupported_config>

The logic change in the patch is to just keep original configuration in
case of -ERANGE error. Otherwise the logic is not changed.