From: Andy King <acking@vmware.com>
To: David Miller <davem@davemloft.net>
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] VMXNET3: Add support for virtual IOMMU
Date: Wed, 21 Aug 2013 06:37:34 -0700 (PDT) [thread overview]
Message-ID: <1944820276.33601674.1377092254160.JavaMail.root@vmware.com> (raw)
In-Reply-To: <20130821.000255.1258155583733908892.davem@davemloft.net>
Adding Greg, since this will apply to a similar patchset I sent out
for VMCI.
----- Original Message -----
> From: Andy King <acking@vmware.com>
> Date: Tue, 20 Aug 2013 10:33:32 -0700
>
> > We can't just do virt_to_phys() on memory that we pass to the device and
> > expect it to work in presence of a virtual IOMMU. We need to add IOMMU
> > mappings for such DMAs to work correctly. Fix that with
> > pci_alloc_consistent() where possible, or pci_map_single() where the
> > mapping is short-lived or we don't control the allocation (netdev).
>
> Please use dma_alloc_coherent() (or in fact dma_zalloc_coherent()),
> dma_map_single() et al., because they are preferred and in particular
> allow specification of GFP_* flags
Sorry about that, I'll fix that and send out a new patch.
Thanks!
- Andy
next prev parent reply other threads:[~2013-08-21 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 17:33 [PATCH] VMXNET3: Add support for virtual IOMMU Andy King
2013-08-21 7:02 ` David Miller
2013-08-21 13:37 ` Andy King [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 16:33 Andy King
2013-08-27 20:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1944820276.33601674.1377092254160.JavaMail.root@vmware.com \
--to=acking@vmware.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).