From: David Howells <dhowells@redhat.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH net-next] rxrpc: Mark expected switch fall-through
Date: Fri, 05 Apr 2019 16:15:52 +0100 [thread overview]
Message-ID: <19488.1554477352@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190401193931.GA1135@embeddedor>
Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> /* Fall through and set IPv4 options too otherwise we don't get
> * errors from IPv4 packets sent through the IPv6 socket.
> */
> -
> + /* Fall through */
Er, no. Please (a) don't remove the blank line that's providing visual
separation and (b) observe that the previous comment already says "Fall
through" right at the beginning, so NAK.
If the compiler doesn't recognise this, then fix the compiler please.
David
prev parent reply other threads:[~2019-04-05 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 19:39 [PATCH net-next] rxrpc: Mark expected switch fall-through Gustavo A. R. Silva
2019-04-04 4:39 ` David Miller
2019-04-04 15:31 ` Gustavo A. R. Silva
2019-04-05 15:15 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19488.1554477352@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).