From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D14C4360F for ; Fri, 5 Apr 2019 15:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF885218A6 for ; Fri, 5 Apr 2019 15:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731243AbfDEPPz (ORCPT ); Fri, 5 Apr 2019 11:15:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfDEPPz (ORCPT ); Fri, 5 Apr 2019 11:15:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE65CDD9C0; Fri, 5 Apr 2019 15:15:54 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52F0061358; Fri, 5 Apr 2019 15:15:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190401193931.GA1135@embeddedor> References: <20190401193931.GA1135@embeddedor> To: "Gustavo A. R. Silva" Cc: dhowells@redhat.com, "David S. Miller" , linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH net-next] rxrpc: Mark expected switch fall-through MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <19487.1554477352.1@warthog.procyon.org.uk> Date: Fri, 05 Apr 2019 16:15:52 +0100 Message-ID: <19488.1554477352@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 05 Apr 2019 15:15:55 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Gustavo A. R. Silva wrote: > /* Fall through and set IPv4 options too otherwise we don't get > * errors from IPv4 packets sent through the IPv6 socket. > */ > - > + /* Fall through */ Er, no. Please (a) don't remove the blank line that's providing visual separation and (b) observe that the previous comment already says "Fall through" right at the beginning, so NAK. If the compiler doesn't recognise this, then fix the compiler please. David