From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: Alex Sidorenko <alexandre.sidorenko@hpe.com>,
netdev@vger.kernel.org, Mahesh Bandewar <maheshb@google.com>
Subject: Re: Bond recovery from BOND_LINK_FAIL state not working
Date: Tue, 07 Nov 2017 11:47:50 +0900 [thread overview]
Message-ID: <19490.1510022870@nyx> (raw)
In-Reply-To: <f3fdd7f7-4398-dc6d-e576-307db7b9bb22@redhat.com>
Jarod Wilson <jarod@redhat.com> wrote:
>On 2017-11-02 9:11 PM, Jay Vosburgh wrote:
[...]
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index 18b58e1376f1..6f89f9981a6c 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -2046,6 +2046,7 @@ static int bond_miimon_inspect(struct bonding *bond)
>> bond_for_each_slave_rcu(bond, slave, iter) {
>> slave->new_link = BOND_LINK_NOCHANGE;
>> + slave->link_new_state = slave->link;
>> link_state = bond_check_dev_link(bond, slave->dev, 0);
>>
>>
>> Alex / Jarod, could you check my logic, and would you be able to
>> test this patch if my analysis appears sound?
>
>This patch looks good, the original reproducing setup successfully
>recovers after the original active slave goes down, even with
>NetworkManager in the mix.
>
>Reviewed-by: Jarod Wilson <jarod@redhat.com>
Thanks, I'll get a formal patch submission out later today.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
prev parent reply other threads:[~2017-11-07 2:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 18:09 Bond recovery from BOND_LINK_FAIL state not working Alex Sidorenko
2017-11-01 21:34 ` Jay Vosburgh
2017-11-02 0:35 ` Jay Vosburgh
2017-11-02 2:37 ` Jarod Wilson
2017-11-02 4:51 ` Jay Vosburgh
2017-11-02 12:47 ` Alex Sidorenko
2017-11-03 1:11 ` Jay Vosburgh
2017-11-03 15:40 ` Alex Sidorenko
2017-11-03 18:26 ` Jay Vosburgh
2017-11-03 19:30 ` Alex Sidorenko
2017-11-03 21:46 ` Jarod Wilson
2017-11-06 6:06 ` Jarod Wilson
2017-11-07 2:47 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19490.1510022870@nyx \
--to=jay.vosburgh@canonical.com \
--cc=alexandre.sidorenko@hpe.com \
--cc=jarod@redhat.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).