From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Vosburgh Subject: Re: Bond recovery from BOND_LINK_FAIL state not working Date: Tue, 07 Nov 2017 11:47:50 +0900 Message-ID: <19490.1510022870@nyx> References: <28118.1509572045@famine> <10968.1509582913@famine> <17092.1509598291@famine> <995.1509671466@famine> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Alex Sidorenko , netdev@vger.kernel.org, Mahesh Bandewar To: Jarod Wilson Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:57438 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753052AbdKGCr6 (ORCPT ); Mon, 6 Nov 2017 21:47:58 -0500 In-reply-to: Content-ID: <19489.1510022870.1@nyx> Sender: netdev-owner@vger.kernel.org List-ID: Jarod Wilson wrote: >On 2017-11-02 9:11 PM, Jay Vosburgh wrote: [...] >> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >> index 18b58e1376f1..6f89f9981a6c 100644 >> --- a/drivers/net/bonding/bond_main.c >> +++ b/drivers/net/bonding/bond_main.c >> @@ -2046,6 +2046,7 @@ static int bond_miimon_inspect(struct bonding *bond) >> bond_for_each_slave_rcu(bond, slave, iter) { >> slave->new_link = BOND_LINK_NOCHANGE; >> + slave->link_new_state = slave->link; >> link_state = bond_check_dev_link(bond, slave->dev, 0); >> >> >> Alex / Jarod, could you check my logic, and would you be able to >> test this patch if my analysis appears sound? > >This patch looks good, the original reproducing setup successfully >recovers after the original active slave goes down, even with >NetworkManager in the mix. > >Reviewed-by: Jarod Wilson Thanks, I'll get a formal patch submission out later today. -J --- -Jay Vosburgh, jay.vosburgh@canonical.com