From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEF225D55B for ; Tue, 25 Feb 2025 06:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740465008; cv=none; b=Q2yxH3+J3ptlyJ1QD8paN6IQBzqQvrA5F2ig6Ro7mT6izxXh3cgcCoYFwyhwJOHk8uxm0l7e6bt/XtW4fWMF2ZYof6BVcg1LbnABNgzZtHRgqHZUFZCiMVgfA+n0biuSkktgzpD7FZ6eQvzf0JmzF+z1tPkzRb7FpO8a6gw/fNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740465008; c=relaxed/simple; bh=RYfyD32sRASx29xi497H3XJdDF3XXVn40eOIf2rnFm0=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=rVFE2qHqmclQge3wwHJKzD/D7eVylWoLs4Fy9atlNnhpbUKQKVgoHC2SFFCWIcsWJUzBMMFJVmuMQndWE8W+0u+2T6qoDDCJkAeJBTdFEXLi8JaQOcuNLqznTHFpMbCdZ4dYvMs5MX+9Q9T0mRzz9uSEvvwyFTi74VcQBeNm69g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ATVTdfAo; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ATVTdfAo" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3f417de5e25so2366360b6e.3 for ; Mon, 24 Feb 2025 22:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1740465004; x=1741069804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=4+mBAQq6Mkez/2/DMWHStf85qnBYyGFLVJqfvqnbkxk=; b=ATVTdfAoZ8/xxq1ZmnjF7OLKA0Xgvb7CoBQQ87W4nCqYvgoKGF1WfWw7itwOEF/kQ2 qSEC712GTgta39biH0N9ptdUCZON99uEGDNtQAHraF5yqKkiQif0P3PLLx4dOpd02hU3 w51m7o1mLP/kdvlplhEAUBZB0iorvyx/M6eRY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740465004; x=1741069804; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4+mBAQq6Mkez/2/DMWHStf85qnBYyGFLVJqfvqnbkxk=; b=Ev6fHGhiHPwcxoYf1dGJ/AhEbFwo2ps7tgsjRm9r0uvO6r5tdp0NrbKxaN5754r6pO tsGGQzy6eYyW6JYTYW0ZRSEHXaIkjPwvcPwXV+G5Oyfx8C2qXA6dSIrwVoa7nRB8peOI LXXrPp97kglcBzb+Nn23PrKCp2h708b4JDGZqqXMEA2ogOtuJ+Cpv8F5QJ/6pawGbCyI nRCYECNivq7GCmQkEIR9qGujZlQ52B1H6YcWW2QlA1biB3mU+XDAN8XrkfTyml3l6Vyl U8m/C8PPx5OmKkm1byazAnZ+xHEzpsBUr0aR9PxsvIx3+l4xJ+WkuOFv4O/ESn8sBbsE oXWQ== X-Forwarded-Encrypted: i=1; AJvYcCXLWdy1WVzcu/mHF3bNgG3bjFHq4FYqZCSXS0FgVzHLnmYFKtPIN9Aowkn2rCytIzleU5gCwkg=@vger.kernel.org X-Gm-Message-State: AOJu0YySQEsYigVH0R8X4zG39jgdAu7CVMYA4N/XeSa9T4JUXVyW+ZCj otmI4OqiE3LfTWCPlFGsOip+oTPJzO5pl788dCXSOz+uIPzkIvTYNm0z0JhPKg== X-Gm-Gg: ASbGnctwM6QrW83FEnu71iATPAVKUIjXZIjLBM8ZAzH4dHzxbHAa6FA/0rFwyS2YbRS VIKW79YI/+q2EfnumrW6ruePZyNrKMYU4JBRgyKgy6pXnPXLNsUiUltww35Vf47kj4J6VKu1+bB PX7u3UqcoDRkDVzwMYkzB/ljPVakip6KQjw+GRKtfwkmB1f3cNyB7aTkzDuaTei3S4AchLEjDbu 92B+C4rgXyk7VAgUobEBswBMZGV90OEfF1IyQQ2dyuK3f2qGD6uCKckmf3i8AYfzV/KBgCMGsK+ IyvayBVT+/V3DV37D64BXLxHmota5ZwT+dpx9myn0pWAi3dw83jGd4nsCgUKMHxy X-Google-Smtp-Source: AGHT+IFdXMbhGx7fP9GFKGlpguOITWaZZGOBzMRAt9OnDAJpr0Tf6LoZNYE9WcUj4WMJOinaxdWK7Q== X-Received: by 2002:a05:6808:3c8f:b0:3f3:e8e7:2001 with SMTP id 5614622812f47-3f424777eb0mr12305946b6e.26.1740465004283; Mon, 24 Feb 2025 22:30:04 -0800 (PST) Received: from [192.168.178.74] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f541bd992bsm190300b6e.16.2025.02.24.22.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 22:30:03 -0800 (PST) From: Arend Van Spriel To: "Kuan-Wei Chiu" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , "Yu-Chun Lin" Date: Tue, 25 Feb 2025 07:29:46 +0100 Message-ID: <1953bcc1790.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20250223164217.2139331-12-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> <20250223164217.2139331-12-visitorckw@gmail.com> User-Agent: AquaMail/1.54.1 (build: 105401536) Subject: Re: [PATCH 11/17] wifi: brcm80211: Replace open-coded parity calculation with parity32() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On February 23, 2025 5:44:54 PM Kuan-Wei Chiu wrote: > Refactor parity calculations to use the standard parity32() helper. > This change eliminates redundant implementations and improves code > efficiency. While the dust settles on the exact implementation from driver perspective looks fine to me so... Acked-by: Arend van Spriel > > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Signed-off-by: Kuan-Wei Chiu > --- > .../wireless/broadcom/brcm80211/brcmsmac/dma.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-)