Netdev List
 help / color / mirror / Atom feed
From: Justin Chen <justin.chen@broadcom.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
	Paolo Abeni <pabeni@redhat.com>,
	phucduc.bui@gmail.com, Doug Berger <opendmb@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/4] net: broadcom: Improve IRQ error handling
Date: Thu, 20 Aug 2026 11:42:27 -0700	[thread overview]
Message-ID: <1958a140-a3ff-4f0c-8982-9695d1dbd8a1@broadcom.com> (raw)
In-Reply-To: <cc18ef57-4f5b-4459-b110-b29bf2c8b8eb@broadcom.com>



On 8/20/26 9:45 AM, Florian Fainelli wrote:
> On 8/20/26 06:30, Paolo Abeni wrote:
>> On 8/20/26 1:14 PM, phucduc.bui@gmail.com wrote:
>>> From: bui duc phuc <phucduc.bui@gmail.com>
>>>
>>> Hi all,
>>>
>>> This series improves IRQ error handling in several Broadcom Ethernet
>>> drivers by propagating IRQ lookup and request errors instead of
>>> silently ignoring them.
>>>
>>> The changes were found by manual code inspection and compile-tested
>>> only.
>> ## Form letter - net-next-closed
>>
>> We have already submitted our pull request with net-next material for 
>> v7.3,
>> and therefore net-next is closed for new drivers, features, code 
>> refactoring
>> and optimizations. We are currently accepting bug fixes only.
>>
>> Please repost when net-next reopens after Aug 31st.
>>
>> RFC patches sent for review only are obviously welcome at any time.
>>
>> See: https://www.kernel.org/doc/html/next/process/maintainer- 
>> netdev.html#development-cycle
>>
> 
> Not seeing much value in these patches, to be honest.

Agreed. I prefer the current behavior. Even if the optional WoL IRQ 
exist, but fails to initialize correctly, the rest of the network 
functions will still work. No need to take down everything in this case.

Thanks,
Justin


      reply	other threads:[~2026-08-20 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 11:14 [PATCH 0/4] net: broadcom: Improve IRQ error handling phucduc.bui
2026-08-20 11:14 ` [PATCH 1/4] net: bcmasp: Use platform_get_irq() for IRQ lookup phucduc.bui
2026-08-20 11:14 ` [PATCH 2/4] net: bcmasp: Propagate WoL IRQ errors from probe phucduc.bui
2026-08-20 11:14 ` [PATCH 3/4] net: systemport: Propagate IRQ lookup errors phucduc.bui
2026-08-20 11:14 ` [PATCH 4/4] net: bcmgenet: Propagate WoL IRQ errors phucduc.bui
2026-08-20 13:30 ` [PATCH 0/4] net: broadcom: Improve IRQ error handling Paolo Abeni
2026-08-20 16:45   ` Florian Fainelli
2026-08-20 18:42     ` Justin Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1958a140-a3ff-4f0c-8982-9695d1dbd8a1@broadcom.com \
    --to=justin.chen@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=phucduc.bui@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox