From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BC801EEA5D for ; Thu, 10 Apr 2025 05:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744261760; cv=none; b=a1LWg8AJ/1dFRV4wCMvyUw6tqNMscmA04l9JsjkwRX6HRMStpdcJ+8D0kYJB8GVwD/XzVrWtp/hOCgv+CCJMAwmw9apVRsMc4Rn6fGTj76YsMab4Z/GuJnfA002159wOJBlvd5TDm9quM/CObRkTgcU69wf2Nri585OD9U76ovs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744261760; c=relaxed/simple; bh=G16oVcschOk1bCBWwdD3ZsJUcsex2zjDzFXRZC7O9eo=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=fhUxBR27rahQz77ZGzQrdrcryOUdkUZHpgwot8x8RFnBj7SBRTf//ysydEeZne69NB65Xo+X2qf4zX0jPBa5YaC3KIsSaMEmMyLFtPw1zymQgMxW888A2YusBrWTt4GYH3zWl0iFrrQX7XG1bl3IedmVVrb+ei/W90NGcT/TE/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Nhyg+23K; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Nhyg+23K" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-6021e3daeabso204535eaf.3 for ; Wed, 09 Apr 2025 22:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744261757; x=1744866557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=G16oVcschOk1bCBWwdD3ZsJUcsex2zjDzFXRZC7O9eo=; b=Nhyg+23KIvdj2ds/dNoqaEQBtAsf+l8ko22/0+4jtvRN2tw9Xc7oxEI8f8BdnYDTiE wy/7saWqUY6bU6A6WaAv1yLARvwdxE1XGz4cX1LXU3HkjRenBGaTqV/cwhECJall2SEs b3T7jLsPsW0YtLGXBqKsEw1OfECpoBHejRrc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744261757; x=1744866557; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G16oVcschOk1bCBWwdD3ZsJUcsex2zjDzFXRZC7O9eo=; b=cG7K6o4Nk8mDTdVTnKrKUXiI7CsYowAQGFK12WYCljLkdFss5XljuA1nRcuQBs4iv0 occsUNNwgMX/cjUbttEoRi8UTO9ic8/80+tgiqeSpNroir0SRA7Ps+x09Eue7sW3X4Vl koe2TF5F4YIhqD75mBD1BciGn2ZLvsjn1PqdTDd97q5OsvHt+aEn2K4Wvqp4miBnVHLf Ctp/w04kApAEEC9QDYZL240MMRaYm1zlaFGTKL3R5tRm67TFfONYwicwT0ovMH4t82Qo JhpLwC0prC+kM0Woq2ayRGAG+tvbgM1MbR9pxWt91G5dohcLVOF1SuVe16QleZh/IAoV 72QQ== X-Forwarded-Encrypted: i=1; AJvYcCVScS+P2Hpk+CwmRBLF8K1RBOmS1i5g//asdV/J9YpF+5zDaC58nl5R52lFU0m/g38AXMGDmXk=@vger.kernel.org X-Gm-Message-State: AOJu0YyfO3HZU3hMwr9URuRKPiBK2pzkkIXzMu+w84DQ9Fm6dpSyV3k1 3Mre4OySkGYmR5SgS1Dyo600S3S0GZPIxbxwX2tPwXmDHa83FOOW1Hfu9LLqAA== X-Gm-Gg: ASbGncuLFCZkEQm9ZrjmaaN/Z2PXOT787wRgePTWkI3dTDsi8JNYeuDbn6BUsVSOneH H1v7Jnu+CpIZYT0ju9QjRYckhwzo5qtlaufk5GGvuHmxDVlhv9Emg4S8w5m1vWnZS+nm7Q035ah Jsawkn7DuTx9HqgJRcCyxiymC3Cj2vlKx2NdOt4evjBYQiepM8pNT73uUb6ibnFM8wAdLThqz/6 avxnAiKJfKsX7H0iKVsMe6lIKMcnCZd3cT+sB3wIcoBc++rypiwUSNG5eqhwLunupMWB+1M4fly x9Nq1gQAvs9u8PvRSfD+WmP3X5cmf/2V6XJdwBqum/w+hQLmOOqhtwwG2oxb/xIZGGmJZ4s5EW9 9heA= X-Google-Smtp-Source: AGHT+IHf2dIBsgMwlqUxzHqfg0izmCh/XeIh4+y37IHWa4xRZwCt6+2s0H2VCnvp55v7eCTsGxhXjQ== X-Received: by 2002:a05:6871:3320:b0:27b:61df:2160 with SMTP id 586e51a60fabf-2d0b383616dmr840067fac.31.1744261757422; Wed, 09 Apr 2025 22:09:17 -0700 (PDT) Received: from [192.168.178.39] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2d096cd3764sm534917fac.31.2025.04.09.22.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 22:09:16 -0700 (PDT) From: Arend Van Spriel To: Johannes Berg , "Kuan-Wei Chiu" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , "Yu-Chun Lin" Date: Thu, 10 Apr 2025 07:08:58 +0200 Message-ID: <1961e19ee10.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net> References: <20250409154356.423512-1-visitorckw@gmail.com> <20250409154356.423512-4-visitorckw@gmail.com> <25b7888d-f704-493b-a2d7-c5e8fff9cfb4@broadcom.com> <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net> User-Agent: AquaMail/1.54.1 (build: 105401536) Subject: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On April 10, 2025 12:06:52 AM Johannes Berg wrote: > On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote: >> >> This is orthogonal to the change to parity_odd() though. More specific >> to the new parity_odd() you can now do following as parity_odd() >> argument is u64: >> >> err = !parity_odd(*(u16 *)p); > > Can it though? Need to be careful with alignment with that, I'd think. My bad. You are absolutely right. Gr. AvS >