From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B49E2EF286 for ; Tue, 17 Jun 2025 16:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750176399; cv=none; b=iqGnMB39Nazl9J54nay+Ijr56km9gAKGEorKCBNqQ1iOZtU4lAQ/MpSgvVjBPle9ER8In0ZRUpoBTU9aPSswyWQXbylJLcpzVzZYAyyKR52n0I6jUcReQ+IrV2HkA0jt6S5D30EQefD3VRssjA7gBEiVWQj4XLSKlXNx69Jf3kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750176399; c=relaxed/simple; bh=o1XHPxZy63aJwpoBVbLCl3BWxUFqib33BiLjtEyywdY=; h=From:To:cc:Subject:In-reply-to:References:MIME-Version: Content-Type:Date:Message-ID; b=EqJPKILACOI7C98IbYTffB7rVKY6FG1EOCX/DrFFfS+0kZsOUWXUz6tXO7MDj56AHIhngQSBrrCxjHQHdiG45fJo9oUaIvL2sz+wjAt5RV62pAkvrNwyzNmqR/jcw6sKuCO5XHCMSoiEcAEZbYOqCe/SerzQcqQ/1CvROsCFDTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jvosburgh.net; spf=pass smtp.mailfrom=jvosburgh.net; dkim=pass (2048-bit key) header.d=jvosburgh.net header.i=@jvosburgh.net header.b=SMO5DGUh; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Cwlo93Qy; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jvosburgh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jvosburgh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jvosburgh.net header.i=@jvosburgh.net header.b="SMO5DGUh"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Cwlo93Qy" Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7E8DF1140088; Tue, 17 Jun 2025 12:06:35 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Tue, 17 Jun 2025 12:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jvosburgh.net; h=cc:cc:content-id:content-transfer-encoding:content-type :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to; s=fm3; t=1750176395; x=1750262795; bh=mLlK6eOejIG/AZal9j/RE 8F4XrUr5J5ycIWdVy/MU2I=; b=SMO5DGUhflUkjxXYFnNvxwp1azjiqUpGH6xB9 ChgKQcMV85y/ar6UW40ArpEnM6wHFGaYcsh1YQxQxq0EHiwv31lUnHqwlJe74/7f jl/CC/kgS/XO1Belidqy6Rl6moTHoG97oSizw/o+sTQpc8nfN0hLl7puFzFngctW GNEDu489ShIj8ynTjrF2Mq7ozfh+QWNATSu3ZeohoSQpNJ0hU3vmva16sVcH30if X5voEFMkSeoenoTHrkAqp5WuPRkwdqrjjcqS7xdg9HIietOvMd9RkoggoDyePTSt KLD1s1Ns4Hg+cxKE5Vhu9bnu1Za/xxQPTA2Nsvt9tfgelXs1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-id :content-transfer-encoding:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1750176395; x=1750262795; bh=mLlK6eOejIG/AZal9j/RE8F4XrUr5J5ycIW dVy/MU2I=; b=Cwlo93Qy5s5B4L8PIOf8lgwQfRmo1eQjr2zrgrFv7IQAiBq2cXG 7x9RUKk6HFEuixQFke3KCzoNmWfsETplguqNoWthBLMnZwmUIp1M/V8JbkgzF0Ii 2RtUuvjozK/yIG9qY+UlscAivwQJO3Xoy5oCn+w8updb/qaMOV3S861vQ3t3COJE fwdoUEASlo7FoL+5WAeyinjSr3tufPc6NhJeCqkRDDZYhnDhYYu0Fh1JWgg+yi3l 1KJvWLIBPRdiawc0EJ38SYxmHDl4ah5fcYVxp7dvOscjzGs0ZXJOwgG2CkaO1jBj S1Khe3r9SAQ+8E8EH19krgDc7VTk4fwWBTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhfogggtgfffkfesthhqredtredtvden ucfhrhhomheplfgrhicugghoshgsuhhrghhhuceojhhvsehjvhhoshgsuhhrghhhrdhnvg htqeenucggtffrrghtthgvrhhnpeeifedvleefleejveethfefieduueeivdefieevleff uddvveeftdehffffteefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehjvhesjhhvohhssghurhhghhdrnhgvthdpnhgspghrtghpthhtohep jedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphhrrgguvggvphhssehlihhnuh igrdhvnhgvthdrihgsmhdrtghomhdprhgtphhtthhopehirdhmrgigihhmvghtshesohhv nhdrohhrghdprhgtphhtthhopegrmhhorhgvnhhoiiesrhgvughhrghtrdgtohhmpdhrtg hpthhtohephhgrlhhiuhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepphhrrgguvggv phesuhhsrdhisghmrdgtohhmpdhrtghpthhtohepfihilhguvghrsehushdrihgsmhdrtg homhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i53714940:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Jun 2025 12:06:34 -0400 (EDT) Received: by famine.localdomain (Postfix, from userid 1000) id A591B9FCA8; Tue, 17 Jun 2025 09:06:33 -0700 (PDT) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id A44599FC65; Tue, 17 Jun 2025 09:06:33 -0700 (PDT) From: Jay Vosburgh To: David Wilder cc: "netdev@vger.kernel.org" , "pradeeps@linux.vnet.ibm.com" , Pradeep Satyanarayana , "i.maximets@ovn.org" , Adrian Moreno Zapata , Hangbin Liu Subject: Re: [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags. In-reply-to: References: <20250614014900.226472-1-wilder@us.ibm.com> <20250614014900.226472-3-wilder@us.ibm.com> <1928187.1750115758@famine> Comments: In-reply-to David Wilder message dated "Tue, 17 Jun 2025 15:45:57 -0000." X-Mailer: MH-E 8.6+git; nmh 1.8+dev; Emacs 29.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1969717.1750176393.1@famine> Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Jun 2025 09:06:33 -0700 Message-ID: <1969718.1750176393@famine> David Wilder wrote: > > >> Here, and further down in bond_arp_ip_target_opt_parse(), >>there's a lot of string handling that seems out place. Why isn't the >>string parsing done in user space (iproute, et al), and the tags passed >>to the kernel in IFLA_BOND_ARP_IP_TARGET as an optional nested >>attribute? > >>>+ } > >> There is no expectation that sysfs should support new bonding >>API elements; only netlink / iproute2 support matters. If sysfs is the >>reason to do the string parsing in the kernel, then I imagine this could >>all move into userspace. >> >> -J > >Module parameter support also requires string parsing in the kernel. Can = that be dropped as well? Yes. New bonding functionality need not be supported by sysfs or module parameters. -J --- -Jay Vosburgh, jv@jvosburgh.net