From: Paul Moore <paul@paul-moore.com>
To: seif@marvell.com
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com,
dima@marvell.com
Subject: Re: [PATCH 1/1] net: fix cipso packet validation when !NETLABEL
Date: Thu, 17 Oct 2013 21:20:45 -0400 [thread overview]
Message-ID: <1970192.CQWcaac4RA@sifl> (raw)
In-Reply-To: <20131017.154742.370913034142395176.davem@davemloft.net>
On Thursday, October 17, 2013 03:47:42 PM David Miller wrote:
> From: Paul Moore <paul@paul-moore.com>
> Date: Mon, 14 Oct 2013 11:12:47 -0400
>
> > On Saturday, October 12, 2013 10:21:50 PM Seif Mazareeb wrote:
> >> When CONFIG_NETLABEL is disabled, the cipso_v4_validate() function could
> >> loop forever in the main loop if opt[opt_iter +1] == 0, this will causing
> >> a
> >> kernel crash in an SMP system, since the CPU executing this function will
> >> stall /not respond to IPIs.
> >>
> >> This problem can be reproduced by running the IP Stack Integrity Checker
> >> (http://isic.sourceforge.net) using the following command on a Linux
> >> machine connected to DUT:
> >>
> >> "icmpsic -s rand -d <DUT IP address> -r 123456"
> >> wait (1-2 min)
> >>
> >> Signed-off-by: Seif Mazareeb <seif@marvell.com>
> >
> > Thanks for sticking with this.
> >
> > Acked-by: Paul Moore <paul@paul-moore.com>
>
> This patch, like all the others Seif submitted, has been corrupted by
> his email client and is this unusable.
Seif, please fix this. If I don't see a new patch by tomorrow I'll go ahead
and resubmit.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2013-10-18 1:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:58 [PATCH 1/1] net: fix cipso packet validation when !NETLABEL Seif Mazareeb
2013-10-11 19:02 ` Paul Moore
2013-10-11 21:04 ` Seif Mazareeb
2013-10-12 11:57 ` Paul Moore
2013-10-13 5:21 ` Seif Mazareeb
2013-10-14 15:12 ` Paul Moore
2013-10-17 19:47 ` David Miller
2013-10-18 1:20 ` Paul Moore [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-18 3:33 Seif Mazareeb
2013-10-18 21:01 ` Paul Moore
2013-10-19 22:56 ` David Miller
[not found] <0DB595A2CB707F458400BE9663B6A72269C004777F@SC-VEXCH2.marvell.com>
2013-10-11 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1970192.CQWcaac4RA@sifl \
--to=paul@paul-moore.com \
--cc=davem@davemloft.net \
--cc=dima@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=seif@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox