From: Gal Pressman <gal@nvidia.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Tariq Toukan <tariqt@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Moshe Shemesh <moshe@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH net 2/6] net/mlx5: Fix misidentification of write combining CQE during poll loop
Date: Sun, 15 Feb 2026 14:13:08 +0200 [thread overview]
Message-ID: <197ef473-b649-421f-bdd6-79f9df1d6dc7@nvidia.com> (raw)
In-Reply-To: <8d3b2da8-e13c-49f8-a8a6-3aa5b307dfe6@intel.com>
On 13/02/2026 0:36, Jacob Keller wrote:
>
>
> On 2/12/2026 2:32 AM, Tariq Toukan wrote:
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/
>> net/ethernet/mellanox/mlx5/core/wc.c
>> index 815a7c97d6b0..29db15c4b978 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
>> @@ -390,12 +390,10 @@ static void mlx5_core_test_wc(struct
>> mlx5_core_dev *mdev)
>> mlx5_wc_post_nop(sq, &offset, true);
>> expires = jiffies + TEST_WC_POLLING_MAX_TIME_JIFFIES;
>> - do {
>> - err = mlx5_wc_poll_cq(sq);
>> - if (err)
>> - usleep_range(2, 10);
>> - } while (mdev->wc_state == MLX5_WC_STATE_UNINITIALIZED &&
>> - time_is_after_jiffies(expires));
>> + while ((mlx5_wc_poll_cq(sq),
>> + mdev->wc_state == MLX5_WC_STATE_UNINITIALIZED) &&
>> + time_is_after_jiffies(expires))
>> + usleep_range(2, 10);
>>
>
> This could be written with poll_timeout_us(), but I don't know if it
> warrants holding up the fix.
Wasn't aware of iopoll.h, will change, thanks Jacob!
next prev parent reply other threads:[~2026-02-15 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:32 [PATCH net 0/6] mlx5 misc fixes 2026-02-12 Tariq Toukan
2026-02-12 10:32 ` [PATCH net 1/6] net/mlx5: Fix multiport device check over light SFs Tariq Toukan
2026-02-12 22:25 ` Jacob Keller
2026-02-12 10:32 ` [PATCH net 2/6] net/mlx5: Fix misidentification of write combining CQE during poll loop Tariq Toukan
2026-02-12 22:36 ` Jacob Keller
2026-02-15 12:13 ` Gal Pressman [this message]
2026-02-12 10:32 ` [PATCH net 3/6] net/mlx5e: Fix misidentification of ASO " Tariq Toukan
2026-02-12 22:38 ` Jacob Keller
2026-02-12 10:32 ` [PATCH net 4/6] net/mlx5e: MACsec, add ASO poll loop in macsec_aso_set_arm_event Tariq Toukan
2026-02-12 10:32 ` [PATCH net 5/6] net/mlx5e: Fix deadlocks between devlink and netdev instance locks Tariq Toukan
2026-02-12 22:41 ` Jacob Keller
2026-02-12 10:32 ` [PATCH net 6/6] net/mlx5e: Use unsigned for mlx5e_get_max_num_channels Tariq Toukan
2026-02-12 22:41 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=197ef473-b649-421f-bdd6-79f9df1d6dc7@nvidia.com \
--to=gal@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jianbol@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox