From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E03B362 for ; Wed, 10 May 2023 00:39:39 +0000 (UTC) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B799840D9 for ; Tue, 9 May 2023 17:39:35 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QGGLL3b1yzLpjD; Wed, 10 May 2023 08:36:42 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 08:39:32 +0800 Subject: Re: [PATCH net-next v1 1/2] net: introduce and use skb_frag_fill_page_desc() To: Paolo Abeni , Igor Russkikh , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michael Chan , Raju Rangoju , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Claudiu Manoil , Dimitris Michailidis , Thomas Petazzoni , Saeed Mahameed , Leon Romanovsky , "Michael S. Tsirkin" , Jason Wang , Ronak Doshi , VMware PV-Drivers Reviewers , Wei Liu , Paul Durrant , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Boris Pismenny , Steffen Klassert , Herbert Xu CC: , "netdev@vger.kernel.org" References: <20230509092656.20308-1-linyunsheng@huawei.com> <20230509092656.20308-2-linyunsheng@huawei.com> From: Yunsheng Lin Message-ID: <198376b3-e515-28db-97a1-20e8905ac935@huawei.com> Date: Wed, 10 May 2023 08:39:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 2023/5/9 18:07, Paolo Abeni wrote: > On Tue, 2023-05-09 at 17:26 +0800, Yunsheng Lin wrote: >> Most users use __skb_frag_set_page()/skb_frag_off_set()/ >> skb_frag_size_set() to fill the page desc for a skb frag. >> >> Introduce skb_frag_fill_page_desc() to do that. >> >> net/bpf/test_run.c does not call skb_frag_off_set() to >> set the offset, "copy_from_user(page_address(page), ...)" >> suggest that it is assuming offset to be initialized as >> zero, so call skb_frag_fill_page_desc() with offset being >> zero for this case. >> >> Also, skb_frag_set_page() is not used anymore, so remove >> it. >> >> Signed-off-by: Yunsheng Lin > > The recipients list is very long, but you forgot to include the most > relevant one: the netdev ML. Thanks for the remainding. > > Probably it's worth splitting this patch in a series with individual > patches touching the net core and the specific device drivers, to that > you could CC only the relevant recipients on each patch. I was debugging the send_mail stript to see why the netdev ML was not included, and ended up sending a few copy of this patchset forgeting to use '--dry-run' option. As there is a few Reviewed-by tags from community now, splitting this patch might need to drop some Reviewed-by tags, which means some patch might need re-reviewing, I am not sure it is worth splitting considering the confusion caused by the above mistake. Please let me know what do you think. Thanks.