From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2D0C282C4 for ; Sat, 9 Feb 2019 19:12:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46539217D8 for ; Sat, 9 Feb 2019 19:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VonLMxIJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbfBITMM (ORCPT ); Sat, 9 Feb 2019 14:12:12 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36828 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbfBITML (ORCPT ); Sat, 9 Feb 2019 14:12:11 -0500 Received: by mail-wm1-f68.google.com with SMTP id p6so9271918wmc.1 for ; Sat, 09 Feb 2019 11:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pJyHtpWhbFuve9/L/bhK2MFp5jAP1T2jzgqtm82CLTg=; b=VonLMxIJfpkW+Rl75beWV2hhtpReYKRw4NHQl5TS+yx9auTHW+5V9CvHgDOW1JIMuS BvTYwTDUTvLeV7HVD7M2OCHsqL5CdmjD3SONwFq169mwDUxw+rwMMSXfdmKm5cqR0u5I cUb5zN/lz1DnDWDhJ39D3nd9Lvb1aHQZdGv007TZ9/n7i+q2ZSzRjMtPEnm/c84W7+r1 ZomlBzeC4RN/mqYV/Y/pkgjb+5iujywAZZfFPI9Q3l81ICOFjrBZsdnct7ZIz7LLCLbP jEBh+F0dN/3xtIEBUyeKUQPi8K/H8Z7M0NSX5eEfqgj5vvkcq5QYwX2T6ZOnehMcTCtc lJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pJyHtpWhbFuve9/L/bhK2MFp5jAP1T2jzgqtm82CLTg=; b=P5mzFt8bd6kk+CK5rWeSNiZ6H/MtUb83zKwaNqcCWIMixzeFp08tJB5T0RZCc8yDhJ DWfDbQ5B+Ka+Zan3Ngg+IJDU7sGPCr2gjbfe2gZ/2rZeP3vzXghCxk2F7jAxpRpqNLnu HhHyiKYuqfW0L8L+F/sCY4gnhIOVmUP/80HREfMrVJR7AJHf1780z0On3eJvOHzUU8Ju nfSW1Vzgd3CLqJwn3X9GflTNrdta9w5kOkIEtFBwfoJuM2HmvtpPFDgpsfRnmId4Cc+w 1vrm8H0/0Idv8JiYezKVsHqnVdETTAzKYc1wU9+FW6CPKucIYxLCM+DZn1ucYzjAWJYV Bcgw== X-Gm-Message-State: AHQUAuZfwrKF2t0CwsUD+PH3DlIiAjQUR+P5+lSeh05DG/At06w87gLR n4nzPHGdqQWYGpgfa8uJDzvLr/fH X-Google-Smtp-Source: AHgI3IbTSutCFAxBcDzP9Pw6YqoM927wvtKHRKFEasd/ZCS9Zb5VHQdCT7iM/FAi6GwJRkBuwndosw== X-Received: by 2002:a5d:6288:: with SMTP id k8mr9262498wru.173.1549739529682; Sat, 09 Feb 2019 11:12:09 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:51b1:297d:6b2f:4788? (p200300EA8BF1E20051B1297D6B2F4788.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:51b1:297d:6b2f:4788]) by smtp.googlemail.com with ESMTPSA id n3sm6300922wmf.46.2019.02.09.11.12.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Feb 2019 11:12:08 -0800 (PST) Subject: Re: [PATCH net-next] net: phy: Add support for asking the PHY its abilities To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <19c1e5c4-2f86-a3ff-e971-a0098c605b3f@gmail.com> <20190209163554.GB30856@lunn.ch> From: Heiner Kallweit Message-ID: <1984f4fa-78df-bb51-5021-306ce87c3a80@gmail.com> Date: Sat, 9 Feb 2019 20:12:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190209163554.GB30856@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09.02.2019 17:35, Andrew Lunn wrote: > On Sat, Feb 09, 2019 at 03:24:47PM +0100, Heiner Kallweit wrote: >> From: Andrew Lunn >> Add support for runtime determination of what the PHY supports, by >> adding a new function to the phy driver. The get_features call should >> set the phydev->supported member with the features the PHY supports. >> It is only called if phydrv->features is NULL. >> >> This requires minor changes to pause. The PHY driver should not set >> pause abilities, except for when it has odd cause capabilities, e.g. >> pause cannot be disabled. With this change, phydev->supported already >> contains the drivers abilities, including pause. So rather than >> considering phydrv->features, look at the phydev->supported, and >> enable pause if neither of the pause bits are already set. > > Hi Heiner > > Ah, cool, these are the patches i was asking for, when you asked > about splitting Maxime's patches. There is one more in my tree which > converts the marvell10g to using this. I think that should be posted > as well. It makes it clear how this should be used, and it replaces > one of the patches in Maxime's set. > I know, it's patch 15 in your series ;) And I'm aware that usually new core functionality is acceptable only if it comes together with a user, to avoid having billions of orphaned good ideas in the code. I focused on the core here to not get lost in all the new stuff, and to provide Maxime with some direction for adjusting his series. >> Signed-off-by: Andrew Lunn >> [hkallweit1@gmail.com: fixed small checkpatch complaint in one comment] > > Thanks. > > Andrew > Heiner