From: Edward Cree <ecree.xilinx@gmail.com>
To: "Íñigo Huguet" <ihuguet@redhat.com>, habetsm.xilinx@gmail.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
Tianhao Zhao <tizhao@redhat.com>
Subject: Re: [PATCH net] sfc: fix null pointer dereference in efx_hard_start_xmit
Date: Wed, 14 Sep 2022 18:50:04 +0100 [thread overview]
Message-ID: <19857eee-cb09-761a-948a-08753b105d1c@gmail.com> (raw)
In-Reply-To: <20220914111135.21038-1-ihuguet@redhat.com>
On 14/09/2022 12:11, Íñigo Huguet wrote:
> Trying to get the channel from the tx_queue variable here is wrong
> because we can only be here if tx_queue is NULL, so we shouldn't
> dereference it. As the above comment in the code says, this is very
> unlikely to happen, but it's wrong anyway so let's fix it.
>
> I hit this issue because of a different bug that caused tx_queue to be
> NULL. If that happens, this is the error message that we get here:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
> [...]
> RIP: 0010:efx_hard_start_xmit+0x153/0x170 [sfc]
>
> Fixes: 12804793b17c ("sfc: decouple TXQ type from label")
> Reported-by: Tianhao Zhao <tizhao@redhat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2022-09-14 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 11:11 [PATCH net] sfc: fix null pointer dereference in efx_hard_start_xmit Íñigo Huguet
2022-09-14 17:50 ` Edward Cree [this message]
2022-09-20 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19857eee-cb09-761a-948a-08753b105d1c@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).