Re: [PATCH net-next 1/2] netlink: specs: handshake: type the remaining key serials s32

["Chuck Lever" <cel@kernel.org>]

On Sun, Sep 6, 2026, at 4:23 PM, Asbjørn Sloth Tønnesen wrote:
> On 9/4/26 7:04 PM, Jakub Kicinski wrote:
>> include/linux/key.h has "typedef int32_t key_serial_t" and commit
>> 160f404495aa ("handshake: Fix sign of key_serial_t fields") converted
>> x509.cert and x509.privkey to s32, but accept.peer-identity,
>> accept.keyring and done.remote-auth were left as u32 - the same
>> quantity typed both ways inside one family, and a generated user space
>> struct with __s32 cert next to __u32 keyring. All three come from
>> key_serial_t storage in net/handshake/tlshd.c (treq->th_peerid[],
>> treq->th_keyring), and special keyrings are legitimately negative
>> (KEY_SPEC_PROCESS_KEYRING is -2).
>> 
>> NLA_U32 and NLA_S32 have the same length and no range check here, so
>> the only wire effect is how the value is printed.
>> 
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> ---
>> CC: cel@kernel.org
>> CC: donald.hunter@gmail.com
>> CC: kernel-tls-handshake@lists.linux.dev
>> ---
>>   Documentation/netlink/specs/handshake.yaml | 6 +++---
>>   net/handshake/genl.c                       | 2 +-
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/netlink/specs/handshake.yaml b/Documentation/netlink/specs/handshake.yaml
>> index ffec12b46759..9ab46da04c49 100644
>> --- a/Documentation/netlink/specs/handshake.yaml
>> +++ b/Documentation/netlink/specs/handshake.yaml
>> @@ -67,7 +67,7 @@ doc: Netlink protocol to request a transport layer security handshake.
>>           enum: auth
>>         -
>>           name: peer-identity
>> -        type: u32
>> +        type: s32
>>           multi-attr: true
>>         -
>>           name: certificate
>> @@ -79,7 +79,7 @@ doc: Netlink protocol to request a transport layer security handshake.
>>           type: string
>>         -
>>           name: keyring
>> -        type: u32
>> +        type: s32
>>     -
>>       name: done
>>       attributes:
>> @@ -93,7 +93,7 @@ doc: Netlink protocol to request a transport layer security handshake.
>>           type: s32
>>         -
>>           name: remote-auth
>> -        type: u32
>> +        type: s32
>>           multi-attr: true
>>   
>>   operations:
>> diff --git a/net/handshake/genl.c b/net/handshake/genl.c
>> index feac1ad063ee..58606c2a4600 100644
>> --- a/net/handshake/genl.c
>> +++ b/net/handshake/genl.c
>> @@ -21,7 +21,7 @@ static const struct nla_policy handshake_accept_nl_policy[HANDSHAKE_A_ACCEPT_HAN
>>   static const struct nla_policy handshake_done_nl_policy[HANDSHAKE_A_DONE_REMOTE_AUTH + 1] = {
>>   	[HANDSHAKE_A_DONE_STATUS] = NLA_POLICY_MAX(NLA_U32, MAX_ERRNO),
>>   	[HANDSHAKE_A_DONE_SOCKFD] = { .type = NLA_S32, },
>> -	[HANDSHAKE_A_DONE_REMOTE_AUTH] = { .type = NLA_U32, },
>> +	[HANDSHAKE_A_DONE_REMOTE_AUTH] = { .type = NLA_S32, },
>>   };
>>   
>>   /* Ops table for handshake */
>
> LGTM.
>
> Reviewed-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

For some reason, this patch (and 1/2) came to my oracle.com address but
never appeared at my cel@kernel.org address.

For both: Acked-by: Chuck Lever <cel@kernel.org>


-- 
Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)