From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88262C47095 for ; Sun, 4 Oct 2020 06:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42105206C3 for ; Sun, 4 Oct 2020 06:46:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IsWc0KHE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725862AbgJDGqA (ORCPT ); Sun, 4 Oct 2020 02:46:00 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:2257 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgJDGp7 (ORCPT ); Sun, 4 Oct 2020 02:45:59 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 03 Oct 2020 23:44:13 -0700 Received: from [10.21.180.76] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 4 Oct 2020 06:45:47 +0000 Subject: Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command To: Jiri Pirko , Moshe Shemesh CC: "David S. Miller" , Jakub Kicinski , Jiri Pirko , , References: <1601560759-11030-1-git-send-email-moshe@mellanox.com> <1601560759-11030-3-git-send-email-moshe@mellanox.com> <20201003075209.GD3159@nanopsycho.orion> From: Moshe Shemesh Message-ID: <1992fb83-5b77-41c3-1498-626c6aa5333b@nvidia.com> Date: Sun, 4 Oct 2020 09:45:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201003075209.GD3159@nanopsycho.orion> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601793853; bh=34T1XSNeRu3FYi1Ic2D1fb3NimeI7zrwJTXhd0kkoko=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=IsWc0KHEMcaYZ9w44A5UiojOkSC8OFgdHkSJ40UikyjXMTt57h5KxJeH1CVqNtn2G e8k7sYN1qwmqXbJfgl+Q65ziwOBAnsRqZJuMF/PVvMVOL/kUgd8m+b+tZUVI6KKt0q d7/X3L5POpF9jG7oSOPUbAtX/BIl46+eb9FM6EPC3whsEAtcdDZ5U/FSIVvwWV49LS FyVTxq5HLABGhDtiVF4695fgrBy/kTUs8Gjl127Av14UfVEq4+MFlsIO+mksYPYoJN 5/UD3SaUSnzpZXoxRL2rIEreDVLQj3FA9tj9JeeSzKqJzuOpllUQ5U/AOOMr2z7huz csIfdJcVmRfLg== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/3/2020 10:52 AM, Jiri Pirko wrote: > Thu, Oct 01, 2020 at 03:59:05PM CEST, moshe@mellanox.com wrote: > > [...] > >> +static int >> +devlink_nl_reload_actions_performed_snd(struct devlink *devlink, >> + unsigned long actions_performed, >> + enum devlink_command cmd, struct genl_info *info) >> +{ >> + struct sk_buff *msg; >> + void *hdr; >> + >> + msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); >> + if (!msg) >> + return -ENOMEM; >> + >> + hdr = genlmsg_put(msg, info->snd_portid, info->snd_seq, &devlink_nl_family, 0, cmd); >> + if (!hdr) >> + goto free_msg; >> + >> + if (devlink_nl_put_handle(msg, devlink)) >> + goto nla_put_failure; >> + >> + if (nla_put_u64_64bit(msg, DEVLINK_ATTR_RELOAD_ACTIONS_PERFORMED, actions_performed, > This should be NLA_BITFIELD, I believe. We use it for other bitfields > too. > OK, I see it now, NLA_BITFIELD32. >> + DEVLINK_ATTR_PAD)) > [...]