From: alexious@zju.edu.cn
To: "Simon Horman" <horms@kernel.org>
Cc: "Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>, "Neil Brown" <neilb@suse.de>,
"Olga Kornievskaia" <kolga@netapp.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Simo Sorce" <simo@redhat.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] SUNRPC: fix some memleaks in gssx_dec_option_array
Date: Mon, 25 Dec 2023 23:49:57 +0800 (GMT+08:00) [thread overview]
Message-ID: <1996a76c.53ca7.18ca1ab27ca.Coremail.alexious@zju.edu.cn> (raw)
In-Reply-To: <20231224212754.GB5962@kernel.org>
>
> On Sun, Dec 24, 2023 at 04:24:22PM +0800, Zhipeng Lu wrote:
> > The creds and oa->data need to be freed in the error-handling paths after
> > there allocation. So this patch add these deallocations in the
> > corresponding paths.
> >
> > Fixes: 1d658336b05f ("SUNRPC: Add RPC based upcall mechanism for RPCGSS auth")
> > Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
>
> ...
>
> > diff --git a/net/sunrpc/auth_gss/gss_rpc_xdr.c b/net/sunrpc/auth_gss/gss_rpc_xdr.c
>
> ...
>
> > @@ -265,29 +265,41 @@ static int gssx_dec_option_array(struct xdr_stream *xdr,
> >
> > /* option buffer */
> > p = xdr_inline_decode(xdr, 4);
> > - if (unlikely(p == NULL))
> > - return -ENOSPC;
> > + if (unlikely(p == NULL)) {
> > + err = -ENOSPC
>
> Hi Zhipeng Lu,
>
> unfortunately the line above causes a build failure.
>
> ...
Sorry for my mistake, I'll send a version 2 of this patch soon.
next prev parent reply other threads:[~2023-12-25 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 8:24 [PATCH] SUNRPC: fix some memleaks in gssx_dec_option_array Zhipeng Lu
2023-12-24 21:27 ` Simon Horman
2023-12-25 15:49 ` alexious [this message]
2023-12-25 17:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1996a76c.53ca7.18ca1ab27ca.Coremail.alexious@zju.edu.cn \
--to=alexious@zju.edu.cn \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simo@redhat.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).