From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EBDCA9EB5 for ; Mon, 4 Nov 2019 20:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF8EF20848 for ; Mon, 4 Nov 2019 20:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729216AbfKDUUA convert rfc822-to-8bit (ORCPT ); Mon, 4 Nov 2019 15:20:00 -0500 Received: from mga17.intel.com ([192.55.52.151]:49942 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbfKDUUA (ORCPT ); Mon, 4 Nov 2019 15:20:00 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 12:19:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,268,1569308400"; d="scan'208";a="401737625" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 04 Nov 2019 12:19:59 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 12:19:59 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 4 Nov 2019 12:19:58 -0800 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmsx602.amr.corp.intel.com ([10.18.126.82]) with mapi id 15.01.1713.004; Mon, 4 Nov 2019 12:19:58 -0800 From: "Bowers, AndrewX" To: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] ice: fix potential infinite loop because loop counter being too small Thread-Topic: [Intel-wired-lan] [PATCH] ice: fix potential infinite loop because loop counter being too small Thread-Index: AQHVkLzKP0Wlq1BZlUGR147KUW8J6Kd7eMkA Date: Mon, 4 Nov 2019 20:19:58 +0000 Message-ID: <19998571b6704752955e3c951b50eb92@intel.com> References: <20191101140017.16646-1-colin.king@canonical.com> In-Reply-To: <20191101140017.16646-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTI1NTNjZjUtMTRmMy00OTc2LTk0MjctMTFlZDFiN2VlMTcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVFYU1JZeGh2OXJqZktQOHV6aFlLUzFiZmZzd3lKdHJDUDZoOG1QVmtqMkZQQVV1cjNlQU1JVG5GYThtazlqTCJ9 dlp-reaction: no-action dlp-version: 11.0.400.15 x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Colin King > Sent: Friday, November 1, 2019 7:00 AM > To: Kirsher, Jeffrey T ; David S . Miller > ; Venkataramanan, Anirudh > ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] ice: fix potential infinite loop because loop > counter being too small > > From: Colin Ian King > > Currently the for-loop counter i is a u8 however it is being checked against a > maximum value hw->num_tx_sched_layers which is a u16. Hence there is a > potential wrap-around of counter i back to zero if > hw->num_tx_sched_layers is greater than 255. Fix this by making i > a u16. > > Addresses-Coverity: ("Infinite loop") > Fixes: b36c598c999c ("ice: Updates to Tx scheduler code") > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/intel/ice/ice_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Andrew Bowers