From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' Date: Tue, 23 Oct 2018 12:33:23 -0700 Message-ID: <19b16ca89b5cde607338513638d4ef8e3a3d2802.camel@perches.com> References: <1540283282-9772-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, pkshih@realtek.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: zhong jiang , kvalo@codeaurora.org Return-path: In-Reply-To: <1540283282-9772-1-git-send-email-zhongjiang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. The patch subject is a bit off and too generic here. This is specific to rtl8723ae and not rtlwifi so it is probably better for the subject to be something like: [PATCH] rtl8723ae: Remove set but not used variables and #defines > Signed-off-by: zhong jiang > --- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --