From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 2/3] net: pktgen: Delete an error message for a failed memory allocation in pktgen_create_thread() Date: Mon, 22 May 2017 11:13:49 +0200 Message-ID: <19b7151b-ce0d-54a9-c079-4d17c31c2339@users.sourceforge.net> References: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: LKML , kernel-janitors@vger.kernel.org To: netdev@vger.kernel.org, Alexey Dobriyan , "David S. Miller" , Eric Dumazet , Florian Westphal , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , John Fastabend , Paolo Abeni , Willem de Bruijn Return-path: Received: from mout.web.de ([212.227.15.3]:50715 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757781AbdEVJOv (ORCPT ); Mon, 22 May 2017 05:14:51 -0400 In-Reply-To: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: From: Markus Elfring Date: Mon, 22 May 2017 10:38:46 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/core/pktgen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index c89f4ad21187..51008ddc7af6 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -3760,7 +3760,5 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn) - if (!t) { - pr_err("ERROR: out of memory, can't create new thread\n"); + if (!t) return -ENOMEM; - } mutex_init(&t->if_lock); t->cpu = cpu; -- 2.13.0