From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Kochetkov <al.kochet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Philippe Reynes <tremyfr@gmail.com>,
Peter Chen <peter.chen@nxp.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
Date: Thu, 20 Apr 2017 10:11:15 -0700 [thread overview]
Message-ID: <19bf7cd3-e83c-62bf-3b01-f574811a9e65@gmail.com> (raw)
In-Reply-To: <1492694974-31023-1-git-send-email-al.kochet@gmail.com>
On 04/20/2017 06:29 AM, Alexander Kochetkov wrote:
> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
>
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-04-20 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 13:29 [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
2017-04-20 17:11 ` Florian Fainelli [this message]
2017-04-21 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19bf7cd3-e83c-62bf-3b01-f574811a9e65@gmail.com \
--to=f.fainelli@gmail.com \
--cc=al.kochet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=tremyfr@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).