Re: [Intel-wired-lan] [PATCH iwl-next 2/2] idpf: add flow steering support

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Ahmed Zaki <ahmed.zaki@intel.com>
Date: Mon, 24 Mar 2025 07:49:38 -0600

> Use the new virtchnl2 OP codes to communicate with the Control Plane to
> add flow steering filters. We add the basic functionality for ADD/Delete
> with TCP/UDP IPv4 only. Support for other OP codes and protocols will be
> added later.
> 
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h        |  14 +
>  .../net/ethernet/intel/idpf/idpf_ethtool.c    | 297 +++++++++++++++++-
>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |   6 +
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 104 ++++++
>  .../net/ethernet/intel/idpf/idpf_virtchnl.h   |   6 +
>  5 files changed, 422 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h
> index d7dbf7d9c7d3..4a76eb56c35f 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -21,6 +21,7 @@ struct idpf_vport_max_q;
>  #include "virtchnl2.h"
>  #include "idpf_txrx.h"
>  #include "idpf_controlq.h"
> +#include "idpf_virtchnl.h"

Nack.

idpf_virtchnl.h was created to reduce the overbloat of idpf.h.
Now you're effectively reverting this effort.

Please look at Git history time to time and avoid including everything
into "one big bad header".

Thanks,
Olek